Re: [PATCH v2 2/2] hwmon:(pmbus/xdp730) Add support for efuse xdp720/xdp730

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Renaming the Kconfig symbol, module, and driver from 'xdp720' to 'xdp730' breaks existing kernel and userspace configurations.
--

commit 83256f5e0c4297d842a3fc2a6730dfe5ce709501
Author: Ashish Yadav <ashish.yadav@infineon.com>

hwmon:(pmbus/xdp730) Add support for efuse xdp720/xdp730

This commit adds support for the Infineon XDP730 Digital eFuse Controller by
updating the existing XDP720 driver. It renames the Kconfig symbol, module,
and source file to reflect the expanded family support.

> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -711,14 +711,14 @@ config SENSORS_XDP710
>  	  This driver can also be built as a module. If so, the module will
>  	  be called xdp710.
>  
> -config SENSORS_XDP720
> -	tristate "Infineon XDP720 family"
> +config SENSORS_XDP730
> +	tristate "Infineon XDP730 family"

[Severity: Medium]
Does this renaming break existing kernel configurations?

When users upgrade, their existing CONFIG_SENSORS_XDP720 setting will be
silently dropped (e.g., during make olddefconfig), resulting in an unintended
loss of hardware monitoring capabilities for the XDP720.

Would it be safer to preserve the existing Kconfig symbol and only update
the prompt and help text to reflect the expanded support?

>  	help
>  	  If you say yes here you get hardware monitoring support for Infineon
> -	  XDP720.
> +	  XDP720 and XDP730 Digital eFuse Controllers.
>  
>  	  This driver can also be built as a module. If so, the module will
> -	  be called xdp720.
> +	  be called xdp730.
>  
>  config SENSORS_XDPE152
>  	tristate "Infineon XDPE152 family"
> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -69,7 +69,7 @@ obj-$(CONFIG_SENSORS_TPS546D24)	+= tps546d24.o
>  obj-$(CONFIG_SENSORS_UCD9000)	+= ucd9000.o
>  obj-$(CONFIG_SENSORS_UCD9200)	+= ucd9200.o
>  obj-$(CONFIG_SENSORS_XDP710)	+= xdp710.o
> -obj-$(CONFIG_SENSORS_XDP720)	+= xdp720.o
> +obj-$(CONFIG_SENSORS_XDP730)	+= xdp730.o

[Severity: Medium]
Will changing the module and driver name to xdp730 break userspace scripts
and expectations?

Any explicit module load rules (e.g., in /etc/modules) or sysfs paths that
currently depend on the old xdp720 name might fail after this update.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529054218.5184-1-Ashish.Yadav@infineon.com?part=2