Re: [PATCH v5 1/2] dt-bindings: display: panel: Add Ilitek ILI9488 panel controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between the hardware model name in the commit message and the defined compatible string. The commit message specifies the panel model as 'E35GH-I-MW800-CB'. However, the compatible string is defined as 'focuslcds,e35gh-i-mw800cb', omitting the hyphen before 'cb'.
--

commit 77323add8dc7854fc38182a5936a43c1c36a096a
Author: Igor Reznichenko <igor@reznichenko.net>

dt-bindings: display: panel: Add Ilitek ILI9488 panel controller

This commit adds device tree bindings for the Ilitek ILI9488 panel
controller used in the FocusLCDs E35GH-I-MW800-CB MIPI DSI panel. It also
adds the focuslcds vendor prefix.

> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9488.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9488.yaml
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9488.yaml

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - focuslcds,e35gh-i-mw800cb

[Severity: Low]
This isn't a bug, but should this compatible string include a hyphen before
the cb?

The commit message specifies the panel model as E35GH-I-MW800-CB, but the
compatible string is defined as focuslcds,e35gh-i-mw800cb without the final
hyphen.

> +      - const: ilitek,ili9488
> +
> +  reg:
> +    maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529062836.203990-1-igor@reznichenko.net?part=1