From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BCCD3BB114 for ; Fri, 29 May 2026 09:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045306; cv=none; b=R1oGueLzqLV4fRHO5kxeFacFkpCqU0Wyho5x1Xg6vSkek6kxOh0g6lEVpgYc+Q+qW/cuX3rOw/dlcl0Q0z80eWjTeVppSmWnii16V/TesuKj8WdRkISj000SCbQ7d/wE2ww/3H+ql/CGwcs9OLZ1koA6TEMFt1fMFNnOKOfHoSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045306; c=relaxed/simple; bh=RiwrfMfK+9HwM3snI59RTZqkgGajThFQsD73EMIB4as=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=sVNmTfUxxae6j3jVvtTtzLEfVGWCSseSA08g604DsK6kX90EbQN2XdmD8PUv91tpX4cPLly+phHXrcF2+fuSVRXeN8tEkQ7IGKvVUxjpBodlvgX74mV27cQ6cZo0irkxH9kzfi5n6GJM7F1t6QrkvqF63Hp3ieb/yGs5Gbr3b2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cYmraARg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cYmraARg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 334F81F00893; Fri, 29 May 2026 09:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780045302; bh=f+RXrnz7H9BHCDJU0Zq3nzEXhVXwcApnBnPAfI54uQ8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cYmraARgsszF2F4BJtjzqR4j/+hq1oGJ+Kl97sXun/8lzxtyrbX/jTkhpidy1T3xa X5/hkR+XYFLK8KbHEmdOYd0WLn6Pr7thIfdkJyol5SwsNeF7ghA4ggj2yFmEJu8sFO K5OTnL3blr8s5VR7Hq0KU9mtVagUcKVVZw9DLZNWdT4h42bpJ9gQGVb0Af5mStZKs3 VIIhHuc6lA9ajahQv50da+3ljaiV6gN46qmfNcStDAUFePrO+d4l1gfz2IDV7IDA9o gdf95KbPOxqthu6CN9BqvHUSIJB1kpIiYK7MNJtO6MmffkSGe0Ua5JiIlcGYXmDzXP czMpapezGCvgw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for Motorola Atrix 4G and Droid X2 Reply-To: sashiko-reviews@lists.linux.dev To: "Svyatoslav Ryhel" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260529083752.44796-3-clamor95@gmail.com> References: <20260529083752.44796-3-clamor95@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 29 May 2026 09:01:41 +0000 Message-Id: <20260529090142.334F81F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Makefile entries are not sorted in alphabetical order. -- commit 603a9b9432cb122e3832a30e5f3ca3092b240477 Author: Svyatoslav Ryhel ARM: tegra: Add device-tree for Motorola Atrix 4G and Droid X2 This commit adds device-tree files for the Motorola Atrix 4G and Droid X2,= =20 which are NVIDIA Tegra20-based smartphones. > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia= /Makefile > index faf591485ada7..3075f26131d4c 100644 > --- a/arch/arm/boot/dts/nvidia/Makefile > +++ b/arch/arm/boot/dts/nvidia/Makefile > @@ -21,6 +21,8 @@ dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) +=3D \ > tegra20-colibri-eval-v3.dtb \ > tegra20-colibri-iris.dtb \ > tegra20-medcom-wide.dtb \ > + tegra20-motorola-olympus.dtb \ > + tegra20-motorola-daytona.dtb \ [Severity: Low] This isn't a bug, but should these Makefile entries be sorted alphabeticall= y? Placing tegra20-motorola-daytona.dtb before tegra20-motorola-olympus.dtb would maintain the existing order of the list. > tegra20-paz00.dtb \ > tegra20-plutux.dtb \ > tegra20-seaboard.dtb \ --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260529083752.4479= 6-1-clamor95@gmail.com?part=3D2