From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A908231827 for ; Fri, 29 May 2026 10:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780049748; cv=none; b=fgCEb6pksUc3sSWvOVP9ikqGRBZUYWuKgzYlvi94oTiD/7pfA5XKxOdqaqL264v9VBVz0Ls5nUl9GLYIIdDgKLUWpUbOfbfneN7k84fLRagiit++7FeA2CcrJZ1rtjoNpkSbA3AFWQyFHfKf798AyTsfrbe9bRJ1xmUyKh9G1c8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780049748; c=relaxed/simple; bh=Vz7Vsg53qSrYbX9aoq0FE7LBFRDofowjQGPv5VDPqWc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=eg07hkBlTv/FHRS2TLuB+z9oLYnnZgo66M1n3m1rl79WQ+SdrSsiGAYmRAyYcUn01MWKFatjyzjSe9BaJkdKj4fQC1tmHF8HG2/AzP1mmsyF7bDBL9J39V+EffQjRv++RtauVw/oKChZYRrhL22t904EBV2zTP1hHfqaAmEfxWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I7vSOz72; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I7vSOz72" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E976B1F00893; Fri, 29 May 2026 10:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780049746; bh=Vz7Vsg53qSrYbX9aoq0FE7LBFRDofowjQGPv5VDPqWc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=I7vSOz72EBi+y3NJKT5ggoCwhl8B85Fli6p/7s1u7boMlczDSYqYtcM2VZgjwy+JI St0VQbf0VkLkvu2uIIOtrDaBZAlMixE+LsZ2Mb2aHoHzSYZAQiu00Yltc9FQSs3jcp 6ODzoVOHc2QEq+1rN+j79v/eGqRla/wvuW7Im4G3jo/zo/tUf76fe0B6jfiFQEk+yC QZePxAflqQIF/stUSHQYaX1eCX+6FsO9h5s9XyiUtZmtqT64QqCxL1wYJKjQXE/D08 IfRgANxwXVL8klXYonG3FAD1tjKnnKJBjuhg45YEuhFA/K3LAREtOoHe/bFOY/bCE/ QmFu6GzgZlGbw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 1/1] arm64: dts: mediatek: mt8186: change CCI OPP scaling mapping Reply-To: sashiko-reviews@lists.linux.dev To: "Mark Tseng" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260529100514.52082-2-chun-jen.tseng@mediatek.com> References: <20260529100514.52082-2-chun-jen.tseng@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 29 May 2026 10:15:45 +0000 Message-Id: <20260529101545.E976B1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Logic inversion in commit message due to a grammatical error. -- commit fce735e343be0e6db7c638f33d66995b238098d4 Author: Mark Tseng arm64: dts: mediatek: mt8186: change CCI OPP scaling mapping This commit updates the CCI OPP table frequencies for the MT8186, raising t= he=20 minimum frequency from 500MHz to 800MHz to prevent the system from stalling. > The original CCI OPP table minimum frequency 500Mhz is too low to cause > system stall, So it need update to new version, 1.4G ~ 0.8G. [Severity: Low] This isn't a bug, but the phrase "too low to cause system stall" literally reads as though the frequency is not high enough to cause a stall. Would it be clearer to write something like "too low, causing a system stal= l" or "so low that it causes a system stall" to avoid inverting the intended meaning? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260529100514.5208= 2-2-chun-jen.tseng@mediatek.com?part=3D1