Re: [PATCH v14 1/6] dt-bindings: iio: adc: add AD4691 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding defines GPIO controller capabilities but fails to include them in the 'required' list and the 'examples' section.
--

commit 602cb115d39dfc0437959b492ddbc73748531d1e
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: adc: add AD4691 family

This commit adds device tree bindings for the Analog Devices AD4691 family 
of multichannel SAR ADCs. It defines the hardware constraints, compatible 
strings, and necessary properties for the four variants in this family.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
[ ... ]
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  '#trigger-source-cells':
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - vio-supply

[Severity: Medium]
Should gpio-controller and #gpio-cells be included in this required list?

According to the dt-bindings subsystem guidelines, when a binding defines
provider capabilities such as a GPIO controller, the corresponding standard
properties must be explicitly added to the required list.

Additionally, would it be necessary to update the examples section below to
include these properties?

The subsystem documentation notes that the examples section must include all
required properties to successfully pass the schema validation checks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-ad4692-multichannel-sar-adc-driver-v14-0-e93c2747dc1f@analog.com?part=1