Re: [PATCH RFC v3 5/6] iio: osf: add UART serdev transport

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure due to access of non-existent `reserved` field in `struct osf_device_status`.
--

commit 63140b0b3643f374150f5ac89882047f831e521f
Author: Jinseob Kim <kimjinseob88@gmail.com>

iio: osf: add UART serdev transport

Register the OSF serdev driver and pass received bytes into the OSF0 stream
parser.

> diff --git a/drivers/iio/opensensorfusion/osf_core.c b/drivers/iio/opensensorfusion/osf_core.c
> new file mode 100644
> index 0000000000000..c867b315865d2
> --- /dev/null
> +++ b/drivers/iio/opensensorfusion/osf_core.c
[ ... ]
> +static int osf_core_validate_device_status(const struct osf_frame *frame)
> +{
> +	struct osf_device_status status;
> +	int ret;
> +
> +	ret = osf_protocol_decode_device_status(frame, &status);
> +	if (ret)
> +		return ret;
> +
> +	if (status.reserved)

[Severity: Low]
Does struct osf_device_status contain a reserved field?

Looking at osf_protocol_decode_device_status(), the struct appears to only
contain uptime_s, status_flags, error_flags, and dropped_frames.

This causes a compilation error (error: 'struct osf_device_status' has no
member named 'reserved') when building this patch.

While I noticed this function is replaced and the invalid check is removed
later in the series by the patch "iio: osf: register IIO devices from
capabilities", each patch in a series should ideally compile independently to
preserve git bisect functionality.

> +		return -EPROTO;
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529121005.1470-1-kimjinseob88@gmail.com?part=5