Re: [PATCH v2 1/3] dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Splitting the `xlnx,zynqmp-clk` binding into a new schema breaks validation because the parent firmware schema still references the old file.
--

commit 1e02d44e7b2b8c89538f05376475e81433856e26
Author: Michal Simek <michal.simek@amd.com>

dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema

The ZynqMP clock controller binding shares only #clock-cells with the
Versal bindings. Move it to a dedicated xlnx,zynqmp-clk.yaml schema.

> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index bef109d163a82..12d060c39bfc4 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -17,9 +17,7 @@ description: |
>  properties:
>    compatible:
>      oneOf:
> -      - enum:
> -          - xlnx,versal-clk
> -          - xlnx,zynqmp-clk
> +      - const: xlnx,versal-clk

[Severity: Low]
Does this change break schema validation for the parent firmware node?

The firmware binding at
Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
still validates its clock-controller child node using a reference to
/schemas/clock/xlnx,versal-clk.yaml#.

Since xlnx,zynqmp-clk is removed from this schema, will dtbs_check now fail
for device trees like arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi that
define the clock-controller under the firmware node?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780063921.git.michal.simek@amd.com?part=1