Re: [PATCH v1 6/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The PWM controller required for the display backlight is not enabled in the overlay.
- [Low] The panel node uses an undocumented compatible string and a non-standard node name.
--

commit 9407fc282e8f0c8e125332b85c771abdd92f5aff
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI

This commit adds a device tree overlay for the Toradex Capacitive Touch
Display 7" DSI on the Aquila DSI_1 interface. It configures the panel,
backlight, touch controller, and the DSI-to-LVDS bridge.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-dsi

> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-7inch-dsi.dtso
> @@ -0,0 +1,149 @@
[ ... ]
> +&{/} {
> +	backlight_pwm3: backlight-pwm3 {
> +		compatible = "pwm-backlight";
> +		brightness-levels = <0 45 63 88 119 158 203 255>;
> +		default-brightness-level = <4>;
> +		/* Aquila PWM_3_DSI (AQUILA B46) */
> +		pwms = <&main_ehrpwm5 0 6666667 0>;
> +	};

[Severity: High]
The main_ehrpwm5 node appears to be disabled by default in the base SoC
device tree and is not enabled in the clover base board file.

Does this overlay need to include a status = "okay" override for
main_ehrpwm5? Without it, the pwm-backlight driver may fail to acquire the
PWM channel, leaving the display backlight non-functional.

> +
> +	panel-lvds-bridge {
> +		compatible = "riverdi,rvt70hslnwca0", "panel-lvds";

[Severity: Low]
Is the riverdi,rvt70hslnwca0 compatible string documented in the device tree
bindings? Undocumented compatible strings and vendor prefixes typically
trigger validation errors.

Additionally, should the node name be changed to a generic name like panel
instead of panel-lvds-bridge to adhere to the device tree specification?

> +		backlight = <&backlight_pwm3>;
> +		data-mapping = "vesa-24";
> +		height-mm = <86>;
> +		width-mm = <154>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529120853.636015-9-ivitro@gmail.com?part=6