Re: [PATCH v2 02/15] arm64: dts: st: add SDMMC2 support on stm32mp25

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `power-domains` property is missing from the `sdmmc2` node.
--

commit 4ee314c8f9ee08a9bd17b8a43369159b8e1356d6
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

arm64: dts: st: add SDMMC2 support on stm32mp25

The SDMMC2 controller supports SD cards, eMMC memories and SDIO devices.

> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 673fbc5632e69..5e46024d22152 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -1667,6 +1667,21 @@ sdmmc1: mmc@48220000 {
>  				status = "disabled";
>  			};
>  
> +			sdmmc2: mmc@48230000 {
> +				compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell";
> +				arm,primecell-periphid = <0x00353180>;
> +				reg = <0x48230000 0x400>, <0x44230800 0x8>;
> +				interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&rcc CK_KER_SDMMC2>;
> +				clock-names = "apb_pclk";
> +				resets = <&rcc SDMMC2_R>;
> +				cap-sd-highspeed;
> +				cap-mmc-highspeed;
> +				max-frequency = <120000000>;
> +				access-controllers = <&rifsc 77>;

[Severity: Medium]
Should this node include a power-domains property?

On the STM32MP25 SoC, peripheral IP blocks are linked to the cluster power
domain. For example, other nodes in the same file use:

    power-domains = <&CLUSTER_PD>;

Looking at the git history, the sdmmc1 node was added early in SoC bringup
before power domains were systematically added to other peripherals.

While the sdmmc1 node is currently missing this property as well, does the
absence of it here cause a regression with runtime power management and
sleep state transitions for the new sdmmc2 controller?

> +				status = "disabled";
> +			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529144707.3931919-1-dario.binacchi@amarulasolutions.com?part=2