Re: [PATCH] arm64: dts: st: add power-domains to sdmmc1 on stm32mp251

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The commit fixes a missing `power-domains` mapping for the `sdmmc1` node in `stm32mp251.dtsi` but neglects to apply the identical fix to the `sdmmc1` node in the sibling SoC device tree `stm32mp231.dtsi`.
--

commit 15c583311b4857c29c6b06ffbc928426a3324c4a
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

arm64: dts: st: add power-domains to sdmmc1 on stm32mp251

This commit adds the missing power-domains property to the sdmmc1 node
in the stm32mp251 device tree. It addresses an early bring-up omission to
align the node with the rest of the peripheral nodes.

> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -1664,6 +1664,7 @@ sdmmc1: mmc@48220000 {
>  				cap-mmc-highspeed;
>  				max-frequency = <120000000>;
>  				access-controllers = <&rifsc 76>;
> +				power-domains = <&CLUSTER_PD>;

[Severity: High]
This isn't a bug introduced by this patch, but should the sdmmc1 node in
the sibling stm32mp231.dtsi device tree also receive this exact update?

Since the early bring-up omission affected these platforms, leaving the
power domain unmapped on the stm32mp231 SoC might lead to a synchronous
external abort or render the controller unusable when the driver attempts
to access unpowered registers. Would it be appropriate to update both SoC
device trees together to prevent runtime failures?

>  				status = "disabled";
>  			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529155607.3948045-1-dario.binacchi@amarulasolutions.com?part=1