Re: [PATCH v2 2/3] media: iris: Add support for Milos (VPU v2.0)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing 'mb_cycles_vsp' in platform capabilities leads to severe VSP hardware under-clocking.
--

commit fb28be6de0281a92b4bb987cda425cdebb0eb9c1
Author: Alexander Koskovich <akoskovich@pm.me>

media: iris: Add support for Milos (VPU v2.0)

Add support for the Milos Iris codec. This only supports the variant
found on the SM7635-AB that has half of it's pipes disabled via efuse.

> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> index 5da90d47f9c6e..1690e463c8ce5 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c
[ ... ]
> @@ -1317,3 +1318,108 @@ const struct iris_platform_data qcs8300_data = {
[ ... ]
> +const struct iris_platform_data milos_data = {
> +	.get_instance = iris_hfi_gen2_get_instance,
> +	.init_hfi_command_ops = iris_hfi_gen2_command_ops_init,
> +	.init_hfi_response_ops = iris_hfi_gen2_response_ops_init,
> +	.get_vpu_buffer_size = iris_vpu_buf_size,
> +	.vpu_ops = &iris_vpu2_ops,
[ ... ]
> +	.inst_caps = &platform_inst_cap_milos,
[ ... ]
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_milos.h b/drivers/media/platform/qcom/iris/iris_platform_milos.h
> new file mode 100644
> index 0000000000000..dacd3ad5aa7e8
> --- /dev/null
> +++ b/drivers/media/platform/qcom/iris/iris_platform_milos.h
[ ... ]
> +static struct platform_inst_caps platform_inst_cap_milos = {
> +	.min_frame_width = 96,
> +	.max_frame_width = 4096,
> +	.min_frame_height = 96,
> +	.max_frame_height = 4096,
> +	.max_mbpf = (4096 * 2176) / 256,
> +	.mb_cycles_vpp = 200,
> +	.mb_cycles_fw = 326389,
> +	.mb_cycles_fw_vpp = 44156,

[Severity: High]
Does this struct unintentionally omit .mb_cycles_vsp?

Because milos_data uses iris_vpu2_ops, the platform expects .mb_cycles_vsp
to be defined for calculating the VSP hardware clock frequency in
iris_vpu2_calc_freq().

With .mb_cycles_vsp missing, it will default to 0. This causes the main
mbs_per_second factor to be multiplied by 0, leading to severe hardware
under-clocking, frame drops, and potential timeouts.

Also, should .mb_cycles_fw and .mb_cycles_fw_vpp be removed here, since they
are used exclusively by VPU v3.0+ platforms?

> +	.num_comv = 0,
> +	.max_frame_rate = MILOS_V1_MAX_FPS,
> +	.max_operating_rate = MILOS_V1_MAX_FPS,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-milos-iris-v2-0-7a763d7195ae@pm.me?part=2