Re: [PATCH net-next v4 1/6] dt-bindings: net: Add support for Airoha AN8801R GbE PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding incorrectly redefines the standard `function-enumerator` property to configure hardware offload modes instead of using it as an ordinal identifier.
--

commit e8af54668e8a0d612e75cb2d23647751c0b3640f
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

dt-bindings: net: Add support for Airoha AN8801R GbE PHY

Add a new binding to support the Airoha AN8801R Series Gigabit
Ethernet PHY.

> diff --git a/Documentation/devicetree/bindings/net/airoha,an8801.yaml b/Documentation/devicetree/bindings/net/airoha,an8801.yaml
> new file mode 100644
> index 0000000000000..fb2f70ceb33ab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,an8801.yaml
[ ... ]
> +    patternProperties:
> +      "^led@[0-2]$":
> +        type: object
> +        description: PHY LEDs
> +        $ref: /schemas/leds/common.yaml#
> +
> +        properties:
> +          reg:
> +            enum: [0, 1, 2]
> +
> +          function-enumerator:
> +            enum: [0, 1, 2]
> +            description: |
> +              Specifies a function for offloading LED functionality to the PHY:
> +              0 - No offloading
> +              1 - Link Availability
> +              2 - Network Activity

[Severity: Medium]
Does this code misuse the function-enumerator property?

According to the standard LED subsystem schema
(Documentation/devicetree/bindings/leds/common.yaml), function-enumerator is
strictly defined as an integer used when more than one instance of the same
function is needed, differing only with an ordinal number (e.g., LAN 1, LAN 2).

Using it here (and in the subsequent PHY driver commit) to configure
hardware-specific offload modes conflates an LED ordinal with hardware
behavior configuration.

Could this establish a non-compliant device tree ABI that might break
standard LED tooling?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-add-airoha-an8801-support-v4-0-1e4837d30ef4@collabora.com?part=1