Re: [PATCH v7 01/15] arm64: dts: qcom: kodiak: Add EL2 overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to "apply it to Kodiak IOT variant devices to create -el2.dtb for each of them alongside 'normal' dtb." However, only `qcs6490-rb3gen2-el2.dtb` is actually added to the Makefile. Other Kodiak IOT variants (e.g., `qcs6490-radxa-dragon-q6a`) are completely omitted.
--

commit dae207f029919c9e5d599bad87797d9c3c3d8c49
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

arm64: dts: qcom: kodiak: Add EL2 overlay

This commit introduces a new EL2-specific DeviceTree overlay for Kodiak
boards to allow booting Linux in EL2 without the Gunyah hypervisor. It
configures remote processor firmware IOMMU streams and the hardware
watchdog while disabling unsupported subsystems like the modem and venus.

Link: https://docs.qualcomm.com/bundle/publicresource/topics/80-70020-4/boot-developer-touchpoints.html#uefi

> Add a EL2-specific DT overlay and apply it to Kodiak IOT variant
> devices to create -el2.dtb for each of them alongside "normal" dtb.

[Severity: Medium]
Is this description accurate? The commit message states the overlay is
applied to all Kodiak IOT variant devices, but only the qcs6490-rb3gen2
device has the -el2.dtb target added below.

> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 4ba8e73064194..28123cdc9de26 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
[ ... ]
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs615-ride-el2.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-radxa-dragon-q6a.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2.dtb
> +qcs6490-rb3gen2-el2-dtbs := qcs6490-rb3gen2.dtb kodiak-el2.dtbo
> +dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2-el2.dtb

If the intent was to also apply this overlay to other variants like
qcs6490-radxa-dragon-q6a, would the fdtoverlay step fail? 

Other Kodiak boards use /delete-node/ for remoteproc_mpss and
remoteproc_wpss because they lack the hardware. It looks like applying
kodiak-el2.dtso to those boards would result in an error when the overlay
attempts to modify these non-existent nodes:

> diff --git a/arch/arm64/boot/dts/qcom/kodiak-el2.dtso b/arch/arm64/boot/dts/qcom/kodiak-el2.dtso
> new file mode 100644
> index 0000000000000..520ed582370da
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kodiak-el2.dtso
[ ... ]
> +&remoteproc_mpss {
> +	status = "disabled";
> +};
> +
> +&remoteproc_wpss {
> +	iommus = <&apps_smmu 0x1c03 0x1>,
> +		 <&apps_smmu 0x1c83 0x1>;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522115936.201208-1-sumit.garg@kernel.org?part=1