Re: [PATCH net-next v5 1/6] dt-bindings: net: Add support for Airoha AN8801R GbE PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `function-enumerator` property is improperly redefined to select hardware-specific LED offloading modes, violating standard Device Tree semantics.
--

commit 431ddd4a15a9545434987e262ef6e5a4a8d95bfe
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

dt-bindings: net: Add support for Airoha AN8801R GbE PHY

This commit adds a new device tree binding for the Airoha AN8801R Series
Gigabit Ethernet PHY.

> diff --git a/Documentation/devicetree/bindings/net/airoha,an8801.yaml b/Documentation/devicetree/bindings/net/airoha,an8801.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,an8801.yaml
[ ... ]
> +    patternProperties:
> +      "^led@[0-2]$":
> +        type: object
> +        description: PHY LEDs
> +        $ref: /schemas/leds/common.yaml#
> +
> +        properties:
> +          reg:
> +            enum: [0, 1, 2]
> +
> +          function-enumerator:
> +            enum: [0, 1, 2]
> +            description: |
> +              Specifies a function for offloading LED functionality to the PHY:
> +              0 - No offloading
> +              1 - Link Availability
> +              2 - Network Activity

[Severity: Medium]
Does this redefine standard device tree semantics for function-enumerator?

In standard LED bindings (leds/common.yaml), function-enumerator is an
ordinal used strictly for disambiguating LED names, such as eth0:green:lan-1.

Since the Linux LED core unconditionally uses function-enumerator to construct
the sysfs device name, setting it to 2 to enable Network Activity offloading
might inadvertently name the LED lan-2 and create an incorrect sysfs ABI.

Could this hardware offloading be configured via standard mechanisms like
linux,default-trigger or a dedicated vendor-specific property instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-add-airoha-an8801-support-v5-0-01aea8dee69b@collabora.com?part=1