Re: [net-next v5 2/4] dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing conditional constraints for `clocks` and `clock-names` allows invalid clock configurations to silently pass schema validation.
--

commit 20465cf4546f85d0e237ceacdadbcf9c0b47c74b
Author: Minda Chen <minda.chen@starfivetech.com>

dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 support

This commit adds support for the jhb100 GMAC, introducing a new compatible
string and corresponding single reset and interrupt properties. It also adds a
new SGMII RX clock to the global clocks list to support the jhb100 hardware.

> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> index 0d1962980f57f..fdcc61c65f87d 100644
> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
[ ... ]
>    clocks:
> +    minItems: 5
>      items:
>        - description: GMAC main clock
>        - description: GMAC AHB clock
>        - description: PTP clock
>        - description: TX clock
>        - description: GTX clock
> +      - description: SGMII RX clock
>  
>    clock-names:
> +    minItems: 5
>      items:
>        - const: stmmaceth
>        - const: pclk
>        - const: ptp_ref
>        - const: tx
>        - const: gtx
> +      - const: sgmii_rx

[Severity: Medium]
Since the global definition of clocks and clock-names now implicitly allows
6 items for the new sgmii_rx clock, do the conditionals for older generations
need updates?

Without explicitly adding maxItems: 5 to the existing if-then blocks for
starfive,jh7110-dwmac and starfive,jh7100-dwmac, it appears device trees
for older hardware can now specify 6 clocks and silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527084108.121416-1-minda.chen@starfivetech.com?part=2