Re: [PATCH v2] dt-bindings: usb: convert PXA USB bindings to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] YAML conversion incorrectly renames properties `marvell,power-sense-low` to `marvell,port-sense-low` and `marvell,power_on_delay` to `marvell,power-on-delay`, breaking validation and backward compatibility.
- [Medium] The `clocks` property is newly enforced as strictly required for `marvell,pxa-ohci`, which breaks schema validation for existing device trees.
--

commit 64a29827cc603985850c4a4a36ae40793189e8ff
Author: Jeremiah Bishop <jbishop.dev@gmail.com>
    
dt-bindings: usb: convert PXA USB bindings to YAML
    
Convert the legacy pxa-usb.txt binding documentation to YAML schemas. The
original text binding documented two distinct devices, which are now split
into marvell,pxa-ohci.yaml and marvell,pxa270-udc.yaml.
    
> diff --git a/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
[ ... ]
> +  marvell,enable-port3:
> +    type: boolean
> +    description: Enable USB port 3 if present.
> +
> +  marvell,port-sense-low:
> +    type: boolean
> +    description: Port sense pin in low-active.

[Severity: Medium]
The original text binding defined this property as "marvell,power-sense-low".
Will renaming "power" to "port" here cause validation failures for existing
device trees that use the legacy property name?

> +
> +  marvell,power-control-low:
> +    type: boolean
> +    description: Power control pin is low-active.
> +
> +  marvell,no-oc-protection:
> +    type: boolean
> +    description: Disable over-current protection.
> +
> +  marvell,oc-mode-perport:
> +    type: boolean
> +    description: Enable per-port over-current protection.
> +
> +  marvell,power-on-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Power On to Power Good time in milliseconds.

[Severity: Medium]
The legacy binding documented this as "marvell,power_on_delay" with an
underscore. Could changing the underscore to a hyphen break ABI compatibility
with older device trees and drivers expecting the original format?

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks

[Severity: Medium]
Is it intentional to enforce "clocks" as a strictly required property here? 

The original pxa-usb.txt binding didn't list "clocks" as required for the 
OHCI controller, and the original example omitted it. Since the schema uses
unevaluatedProperties: false, will enforcing this new requirement cause 
existing valid device trees to fail schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260530022955.32728-1-jbishop.dev@gmail.com?part=1