Re: [PATCH 1/2] dt-bindings: clock: qcom: add lcc-msm8660 LPASS clock IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a new dt-bindings header for the MSM8x60 LPASS Clock Controller but entirely omits the required update to the corresponding YAML schema (`Documentation/devicetree/bindings/clock/qcom,lcc.yaml`).
--

commit 2ab7502c050fb596d568ab63294755ed48d68189
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: clock: qcom: add lcc-msm8660 LPASS clock IDs

This commit introduces the device tree binding clock-ID header for the
MSM8x60 family Low Power Audio SubSystem Clock Controller. The header
enumerates the LPASS clocks to prepare for the new driver.

> diff --git a/include/dt-bindings/clock/qcom,lcc-msm8660.h b/include/dt-bindings/clock/qcom,lcc-msm8660.h
> new file mode 100644
> index 0000000000000..d5d9b0d71a78f
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,lcc-msm8660.h

[Severity: Low]
Is there a missing update to the corresponding YAML binding schema?

Documentation/devicetree/bindings/clock/qcom,lcc.yaml currently lists
compatible strings like:

properties:
  compatible:
    enum:
      - qcom,lcc-apq8064
      - qcom,lcc-ipq8064
      - qcom,lcc-mdm9615
      - qcom,lcc-msm8960

Should qcom,lcc-msm8660 be added to this enum and any corresponding if-then
conditional blocks to allow device tree nodes using this compatible string
to pass validation?

> @@ -0,0 +1,48 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2014, The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_LCC_MSM8660_H
> +#define _DT_BINDINGS_CLK_LCC_MSM8660_H

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780148149.git.github.com@herrie.org?part=1