From: sashiko-bot@kernel.org
To: "Markus Probst via B4 Relay"
<devnull+markus.probst.posteo.de@kernel.org>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org,
ojeda@kernel.org
Subject: Re: [PATCH v14 1/2] dt-bindings: embedded-controller: Add synology microp devices
Date: Sat, 30 May 2026 23:05:06 +0000 [thread overview]
Message-ID: <20260530230506.CBD331F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260531-synology_microp_initial-v14-1-1377d425b24b@posteo.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The compatible string `synology,ds1221rpp-microp` is a typographical error for `synology,rs1221rpp-microp`.
--
commit 75e2ac8371810f3cce7ca7c6e847f04807d5bf10
Author: Markus Probst <markus.probst@posteo.de>
dt-bindings: embedded-controller: Add synology microp devices
This commit introduces device tree bindings for the Synology Microp
microcontrollers found on Synology NAS devices. These controllers manage
LEDs, fan speeds, power behavior, and other hardware features across various
NAS models.
> diff --git a/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
> new file mode 100644
> index 0000000000000..eb1c9d3fac074
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
[ ... ]
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - synology,ds1221rpp-microp
[Severity: Medium]
This isn't a bug, but is this compatible string a typo for
synology,rs1221rpp-microp?
Synology uses "RS" (RackStation) for models with the "RP+" designation
(Redundant Power Plus). There is no DiskStation ("DS") model named DS1221RP+.
This string is also grouped with other RackStation models and correctly falls
back to synology,rs1221p-microp.
> + - synology,rs822p-microp
> + - synology,rs422p-microp
> + - const: synology,rs1221p-microp
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de?part=1
next prev parent reply other threads:[~2026-05-30 23:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 22:57 [PATCH v14 0/2] Introduce Synology Microp driver Markus Probst via B4 Relay
2026-05-30 22:57 ` [PATCH v14 1/2] dt-bindings: embedded-controller: Add synology microp devices Markus Probst via B4 Relay
2026-05-30 23:05 ` sashiko-bot [this message]
2026-05-30 22:57 ` [PATCH v14 2/2] platform: Add initial synology microp driver Markus Probst via B4 Relay
2026-05-30 23:16 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530230506.CBD331F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+markus.probst.posteo.de@kernel.org \
--cc=ojeda@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox