From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CFC418BBAE; Mon, 1 Jun 2026 02:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780280781; cv=none; b=HS0I30lo63jrxGwLbarJLF6JHgNQOwc8dg1FGcyW785ouavcF1MuK487P7t3drMeJZdAVX1JiG9907+0AN4Ah5xblxOVpgFhtbG0bMk1iz3KWc1OuzpyrO4ShowBS4MCeOQ0H7hki9PAK/vXggdrBBy1wENa/xLFL4pt3stHM0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780280781; c=relaxed/simple; bh=U/+5R1lWRqJAsWn4rvOd9TEJGh0tSpWWdjHqo27vY3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rnkNlvph/rOyoFgkgj7Ok9i0jcuWwZwLCZTXR+qOQxlP5BTrH/NPhorbjLiXCohhvENki5cNoQfdxZfriTK3NWXpgcoh6PQHEN6k/P37Oa29TmSlEEOkzmamC0da76lj4xIBpKJsk3vKGd081C3rsxy5XHXy2630P/yMUlpY6nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=epo7cXxQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="epo7cXxQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5E031F00893; Mon, 1 Jun 2026 02:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780280780; bh=UEW+CBPeGaXOv67OjmaNomjMEwykYbnfDwfMc30LrEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=epo7cXxQUr3DwHKtUDowiQXL3Pcl9gODiCePLoen85tE7/sWnLsi+fLm7T6oko9/d z58c3fj7e3ux48yNUPL6lQn5wu2AhBuW46cmCJY+gMbRwSX4DQTt6P1SLKRPAhC/F3 EcjsrztO5TlWmMxux6d5MXYoCn7nFa0II4noM/H90C4Y0oU3dHknsawXXLMIarMBxp 7iConc+bfzVDgHNoBkNhs+NUZaY1Ff82k8/+PHHFmFh1zXyM3CJxYTssR11XYMaH2P vFdydS7yF5eYrDqPVGsvc58HrHMeD6zPsMQvoiJZZdEhmmqDHGvFVJ/FZedPNXClw/ RLu5eW7UN3Lww== Date: Sun, 31 May 2026 21:26:19 -0500 From: Rob Herring To: Biju Das Cc: sashiko-reviews@lists.linux.dev, conor+dt@kernel.org, devicetree@vger.kernel.org, wsa+renesas@sang-engineering.com, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: bridge: Document Renesas RZ/G3L LVDS encoder Message-ID: <20260601022619.GA3961324-robh@kernel.org> References: <20260524194457.479681-2-biju.das.jz@bp.renesas.com> <20260524195829.960401F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 25, 2026 at 08:45:00AM +0100, Biju Das wrote: > Hi Bot, > > On Sun, May 24, 2026 at 8:58 PM wrote: > > > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > - [Low] The compatible string 'renesas,r9a08g046-lvds-cmn' is used in the dt-binding example but is not documented. > > - [Low] The parent node 'lvds-cmn' in the example lacks a 'ranges' property, breaking address translation for its child nodes. > > -- > > > > commit be595c0db2d85d9ea1396f0f30ac7ad75f4101fe > > Author: Biju Das > > > > dt-bindings: display: bridge: Document Renesas RZ/G3L LVDS encoder > > > > Documents the LVDS encoder IP found on the RZ/G3L SoC. It supports > > single-link mode and shares a peripheral clock and reset signal with the > > MIPI-DSI interface. > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,r9a08g046-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,r9a08g046-lvds.yaml > > > new file mode 100644 > > > index 0000000000000..b1f6d020ae7b1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,r9a08g046-lvds.yaml > > > > [ ... ] > > > > > +examples: > > > + - | > > > + #include > > > + > > > + lvds-cmn@108a0000 { > > > + compatible = "renesas,r9a08g046-lvds-cmn", > > > + "simple-mfd", "syscon"; > > > > [Severity: Low] > > Is this compatible string documented somewhere else? It looks like > > renesas,r9a08g046-lvds-cmn isn't present in the tree, which might cause > > dt_binding_check to fail when it validates the example. > > This compatible is documented and is in next [1]. > > Q1) Can you please reun the AI review with [1] ? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20260522&id=51284d8b1dbcd7fa0220c49eeab29b14617e0d88 > > > > > > + reg = <0x108a0000 0x10000>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > > [Severity: Low] > > Does this parent node need a ranges property? Without it, address translation > > for the child node's reg = <0x10 0x8> might fail, and dtc often warns about > > missing ranges in simple-mfd nodes with children. > > I don't get any error or dtc warnings. Have you ran dt-binding check > before providing > such comment? There probably isn't any warning, but sashiko is correct that 'ranges' should be present. The schema for the parent should require 'ranges'. The 'simple-mfd' binding does not as not all simple-mfd's have MMIO addresess in the child nodes. Rob