From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8709E288C81 for ; Mon, 1 Jun 2026 09:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304526; cv=none; b=n16C4SwCbIQmMUyVHn62PMGXoc9wJ5lil3eGeMFP/v8O0is0XHyf1bRr+gAzERYGQ0ZPRz7Hao+kQEwiyegGRfP6oTD1X5YI89ZpmzeBIqs0N/lSovazsruHAqfU/Hg1fnFQBcyWMOwZ7MOYy4O5NICSUIhVTxm9Sf8+QmoN31c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304526; c=relaxed/simple; bh=/m/r3/MmD67npLVc5QoTfJhBG7yS7au6/SGGE0g9EZU=; h=From:Subject:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=GGsPIehSjNn1R1IPDjm0I1lLsodHssBGPBYC1N28s8gTuNdZ9nSEOz+Srpm35UDN+zTD9D4YRJXDr/20bMLELTiMSEIBRqOC3k2S4afDL7J5ubKwEgJ1AF7PjDRYn4AZ6lVbGQEJ7+ivsqiY/+kZPqsuTdp5DcKxVelMSScPt3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nio+t45J; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nio+t45J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 076BC1F00893; Mon, 1 Jun 2026 09:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780304525; bh=zsEtpWCO9tRQHIEn5l0DB8eeRdmMjiVVrS9JBiMf3HY=; h=From:Subject:Reply-To:Cc:In-Reply-To:References:Date; b=Nio+t45JPMQ0TXmnhhXHBFjHx6152qQAk+NReIhPhlvx1mk6vke/kntvGC4hm0EFv 6JaAn9zM6RXXo/tgAEdUZSZdCpl7heJ481tMpmQ168kP+dgBEBzkR0Af6gvyNZ081H vOceigznbeKjclzoQXWSwC8q9ce5wuUXJUUBK/Q6KpUA0EHgaM0EC7cWa/LUKLfvQR ZZ1G8GZ1XH4LyRtpCk3VD0JaNJCDDshoi1CibPFjHOH/cezldZhuhwdn2LGosyjm0/ AxYfZfKGe437a3+tXrakygjOGNkxRJYfW7O/NERoUpHIeAlrxtH4lzs+WTfYCZ80wi 40/C0+0WsMWDQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 2/5] arm64: dts: ti: k3-am62p-ti-ipc-firmware: Move wkup reserved memory Reply-To: sashiko-reviews@lists.linux.dev Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260601-topic-am62a-ioddr-dt-v6-19-v5-2-3856a023aff2@baylibre.com> References: <20260601-topic-am62a-ioddr-dt-v6-19-v5-2-3856a023aff2@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 01 Jun 2026 09:02:04 +0000 Message-Id: <20260601090205.076BC1F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Moving `wkup_r5fss0_core0_memory_region` to the shared `k3-am62p-t= i-ipc-firmware.dtsi` silently truncates the reserved memory size for Verdin= boards from 30MB to 15MB. - [Medium] Moving `wkup_r5fss0_core0_memory_region` to the shared `k3-am62p= -ti-ipc-firmware.dtsi` causes fatal `dtc` duplicate label errors and overla= pping reserved memory regions for Var-SOM boards. -- commit 65cd200377411c4597f1b662700915ea23cfe5f8 Author: Markus Schneider-Pargmann (TI) arm64: dts: ti: k3-am62p-ti-ipc-firmware: Move wkup reserved memory The commit moves the wkup_r5fss0_core0 memory regions to a common k3-am62p-ti-ipc-firmware.dtsi file to combine identical definitions across boards. > Move the reserved memory regions used for wkup_r5fss0_core0 to the > k3-am62p-ti-ipc-firmware.dtsi. These are all the same for the other > boards as well, so we can combine them here similar to what is already > done for the mcu_r5fss0_core0 memory regions. [Severity: High] Are these regions exactly the same for all other boards? k3-am62p-verdin.dtsi explicitly defines the wkup_r5fss0_core0_memory_region with a size of 30MB (0x01e00000): wkup_r5fss0_core0_memory_region: memory@9c900000 { compatible =3D "shared-dma-pool"; reg =3D <0x00 0x9c900000 0x00 0x01e00000>; no-map; }; Because k3-am62p-verdin.dtsi includes k3-am62p-ti-ipc-firmware.dtsi at the very end of the file, dtc cleanly merges the identically-named node paths, = and the new generic definition silently overrides the board-specific 30MB size down to 15MB. Does this halving of the available memory for IPC on Verdin boards cause firmware load failures or runtime out-of-memory crashes on the R5 core? (Note: A subsequent patch in the series 'arm64: dts: ti: k3-am62p-ti-ipc-firmware: Split r5f memory region' changes the label and si= ze to 1MB, which further truncates the region without fixing the underlying overwrite.) > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-ti-ipc-firmware.dtsi b/arch/= arm64/boot/dts/ti/k3-am62p-ti-ipc-firmware.dtsi > index 5d7f701420e2d..12902231e58a7 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-ti-ipc-firmware.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-ti-ipc-firmware.dtsi > @@ -17,6 +17,18 @@ mcu_r5fss0_core0_memory_region: memory@9b900000 { > reg =3D <0x00 0x9b900000 0x00 0xf00000>; > no-map; > }; > + > + wkup_r5fss0_core0_dma_memory_region: memory@9c800000 { > + compatible =3D "shared-dma-pool"; > + reg =3D <0x00 0x9c800000 0x00 0x100000>; > + no-map; > + }; [Severity: Medium] Will this cause dtc duplicate label errors and overlapping regions for Var-SOM boards? k3-am62p5-var-som.dtsi defines its reserved memory nodes using non-standard node names (r5f-dma-memory@9c800000 and r5f-memory@9c900000): wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 { compatible =3D "shared-dma-pool"; reg =3D <0x00 0x9c800000 0x00 0x00100000>; no-map; }; Since the node names differ between the board file and the generic include (r5f-dma-memory vs memory), dtc won't merge them. Because both sets of nodes reuse the exact same node labels (wkup_r5fss0_core0_dma_memory_region), could this trigger a fatal duplicate label compilation error that breaks the build, or emit duplicate, overlappi= ng reserved-memory regions at boot if bypassed? > + > + wkup_r5fss0_core0_memory_region: memory@9c900000 { > + compatible =3D "shared-dma-pool"; > + reg =3D <0x00 0x9c900000 0x00 0xf00000>; > + no-map; > + }; > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260601-topic-am62= a-ioddr-dt-v6-19-v5-0-3856a023aff2@baylibre.com?part=3D2