Re: [PATCH 2/7] wifi: ath11k: enable support for WCN6851

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing MODULE_FIRMWARE() declaration for WCN6855 hw1.1
--

commit 9dd00bb0ca92daf6393c487f5ce3b3c5fb3cc6a4
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

wifi: ath11k: enable support for WCN6851

The WCN6851, found e.g. on SM8350 platforms, is an earlier version of
WCN6855 platform. It identifies itself as hw1.1. Copy WCN6855 hw 2.0
configuration to support hw1.1 version.

> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index 3f6f4db5b7ee1..7e997016cf6e9 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
[ ... ]
> @@ -393,6 +393,98 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
>  		.cfr_num_stream_bufs = 0,
>  		.cfr_stream_buf_size = 0,
>  	},
> +	{
> +		.name = "wcn6855 hw1.1",
> +		.hw_rev = ATH11K_HW_WCN6855_HW11,
> +		.fw = {
> +			.dir = "WCN6855/hw1.1",

[Severity: Medium]
Since this configures the driver to request firmware from the "WCN6855/hw1.1"
directory, does this also require a corresponding MODULE_FIRMWARE() declaration
in drivers/net/wireless/ath/ath11k/pci.c?

Without the MODULE_FIRMWARE() macro for this directory, userspace initramfs
generation tools may not be aware of the dependency. This could result in the
firmware being omitted from the initramfs, causing request_firmware() to fail
if the driver is loaded during early boot.

> +			.board_size = 256 * 1024,
> +			.cal_offset = 128 * 1024,
> +		},

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601-sm8350-wifi-v1-0-242917d88031@oss.qualcomm.com?part=2