Re: [PATCH v2 2/2] pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Kconfig symbol ARCH_ULTRARISC is referenced in 'depends on' and 'default' but is not defined anywhere in the kernel tree.
--

commit ae98cd11bdead29c422db358de808560e3f3ab23
Author: Jia Wang <wangjia@ultrarisc.com>

pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver

This commit adds support for the pin controller on the UltraRISC DP1000 SoC.
It provides mux selection for pins in ports A, B, C, D, and LPC, as well as
basic pin configuration controls.

[ ... ]

> diff --git a/drivers/pinctrl/ultrarisc/Kconfig b/drivers/pinctrl/ultrarisc/Kconfig
> new file mode 100644
> index 0000000000000..a9257dda5d656
> --- /dev/null
> +++ b/drivers/pinctrl/ultrarisc/Kconfig
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config PINCTRL_ULTRARISC
> +	tristate
> +	depends on OF
> +	depends on ARCH_ULTRARISC || COMPILE_TEST

[Severity: Medium]
Does ARCH_ULTRARISC exist in the kernel tree? I couldn't find a definition for
this Kconfig symbol. If it's missing, this driver will only be selectable
when COMPILE_TEST is enabled, leaving it disabled for its actual hardware
target.

> +	select PINMUX
> +	select GENERIC_PINCTRL_GROUPS
> +	select GENERIC_PINCONF
> +	select GENERIC_PINMUX_FUNCTIONS
> +	select GPIOLIB
> +
> +config PINCTRL_ULTRARISC_DP1000
> +	tristate "UltraRISC DP1000 SoC Pinctrl driver"
> +	select PINCTRL_ULTRARISC
> +	depends on OF && HAS_IOMEM
> +	depends on ARCH_ULTRARISC || COMPILE_TEST
> +	default ARCH_ULTRARISC

[Severity: Medium]
Similarly here, ARCH_ULTRARISC is used in the depends on and default directives
but appears to be undefined.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601-ultrarisc-pinctrl-v2-0-07ac5130a96d@ultrarisc.com?part=2