From: Jonathan Cameron <jic23@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: "Wadim Mueller" <wafgo01@gmail.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Maxwell Doose" <m32285159@gmail.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] iio: flow: add Sensirion SLF3S liquid flow sensor driver
Date: Mon, 1 Jun 2026 10:41:13 +0100 [thread overview]
Message-ID: <20260601104113.77f47c58@jic23-huawei> (raw)
In-Reply-To: <ahzWI-bQwnQ8ogFL@debian-BULLSEYE-live-builder-AMD64>
Just picking one thing to add to from the set of good points from Marcelo.
> ...
> > +static const struct iio_chan_spec_ext_info slf3s_ext_info[] = {
> > + IIO_ENUM("medium", IIO_SHARED_BY_TYPE, &slf3s_medium_enum),
> > + IIO_ENUM_AVAILABLE("medium", IIO_SHARED_BY_TYPE, &slf3s_medium_enum),
> We should probably document the new 'medium' ABI.
> For consolidated ABI, we document it in Documentation/ABI/testing/sysfs-bus-iio.
> Since this is new stuf, maybe start with a separate ABI doc
> (e.g. Documentation/ABI/testing/sysfs-bus-iio-slf3s) ?
Definitely needs docs but maybe go one up sysfs-bus-iio-flow.
This is intended to be a generic ABI but one specific to flow sensors.
>
> > + { }
> > +};
>
> With best regards,
> Marcelo
next prev parent reply other threads:[~2026-06-01 9:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 20:54 [PATCH v3 0/3] iio: flow: Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-05-30 20:54 ` [PATCH v3 1/3] iio: types: add IIO_VOLUMEFLOW channel type Wadim Mueller
2026-05-31 18:09 ` Marcelo Schmitt
2026-06-01 9:42 ` Jonathan Cameron
2026-06-03 14:08 ` Wadim Mueller
2026-06-04 8:44 ` Jonathan Cameron
2026-06-07 10:45 ` Wadim Mueller
2026-06-08 8:53 ` Rodrigo Alencar
2026-06-08 12:24 ` Wadim Mueller
2026-06-09 8:32 ` Rodrigo Alencar
2026-06-03 14:17 ` Andy Shevchenko
2026-05-30 20:54 ` [PATCH v3 2/3] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-05-31 17:45 ` Marcelo Schmitt
2026-05-31 17:50 ` Marcelo Schmitt
2026-06-03 14:08 ` Wadim Mueller
2026-06-03 14:43 ` Marcelo Schmitt
2026-06-03 14:48 ` Krzysztof Kozlowski
2026-06-01 9:44 ` Jonathan Cameron
2026-06-01 11:53 ` Krzysztof Kozlowski
2026-06-01 14:09 ` Jonathan Cameron
2026-06-03 14:08 ` Wadim Mueller
2026-06-03 14:29 ` Krzysztof Kozlowski
2026-06-04 9:03 ` Jonathan Cameron
2026-06-04 11:22 ` Krzysztof Kozlowski
2026-06-05 12:21 ` Jonathan Cameron
2026-06-07 8:30 ` Krzysztof Kozlowski
2026-06-11 10:35 ` Wadim Mueller
2026-06-11 10:42 ` Krzysztof Kozlowski
2026-06-12 18:05 ` Jonathan Cameron
2026-06-12 22:00 ` Conor Dooley
2026-05-30 20:54 ` [PATCH v3 3/3] iio: flow: add Sensirion SLF3S liquid flow sensor driver Wadim Mueller
2026-05-30 21:14 ` sashiko-bot
2026-05-31 23:59 ` Maxwell Doose
2026-06-01 9:38 ` Jonathan Cameron
2026-06-01 0:45 ` Marcelo Schmitt
2026-06-01 9:41 ` Jonathan Cameron [this message]
2026-06-03 14:08 ` Wadim Mueller
2026-06-01 9:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601104113.77f47c58@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=wafgo01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox