Re: [PATCH v2 1/2] arm64: dts: rockchip: add Vicharak Axon board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `enable-gpios` property is invalid for the `rockchip,rk3588-dw-hdmi-qp` compatible binding and is ignored by the driver, leaving the HDMI ports unpowered.
- [High] The `rk806_dvs1_null` pinctrl node incorrectly configures `gpio_pwrctrl2` instead of `gpio_pwrctrl1` due to a copy-paste error.
--

commit 9e5cc3349cf78765922014a014dd0a775c777bef
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>

arm64: dts: rockchip: add Vicharak Axon board

Add initial support for the Vicharak Axon single-board computer based on
the Rockchip RK3588 SoC.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-vicharak-axon.dts b/arch/arm64/boot/dts/rockchip/rk3588-vicharak-axon.dts
> new file mode 100644
> index 0000000000000..fecd13a52e88a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-vicharak-axon.dts
[ ... ]
> +&hdmi0 {
> +	enable-gpios = <&gpio1 RK_PB0 GPIO_ACTIVE_HIGH>;
[Severity: High]
The dw-hdmi-qp binding does not support the enable-gpios property, so the
driver will not parse this.

If this GPIO controls power to the HDMI port, will the port remain unpowered
and non-functional? If this is meant to enable FRL, should this use the
frl-enable-gpios property instead?

> +	status = "okay";
> +};
[ ... ]
> +&hdmi1 {
> +	enable-gpios = <&gpio1 RK_PA7 GPIO_ACTIVE_HIGH>;
[Severity: High]
Similarly to hdmi0 above, does this enable-gpios property need to be changed
since it is not parsed by the dw-hdmi-qp driver?

> +	status = "okay";
> +};
[ ... ]
> +	pmic@0 {
> +		reg = <0>;
> +		compatible = "rockchip,rk806";
[ ... ]
> +		rk806_dvs1_null: rk806_dvs1_null {
> +			pins = "gpio_pwrctrl2";
[Severity: High]
Is this pins assignment correct? It configures gpio_pwrctrl2 instead of
gpio_pwrctrl1 for rk806_dvs1_null, which looks like a copy-paste error.

This could leave the actual DVS1 pin unconfigured and susceptible to
unintentional voltage scaling from floating signals.

> +			function = "pin_fun0";
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601132529.139172-1-hrushirajg23@gmail.com?part=1