Re: [PATCH V3 1/6] dt-bindings: power: supply: sgm41542: document sgm41542

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The binding defines power supply properties like 'monitored-battery' but fails to include a root-level reference to the core 'power-supply.yaml' schema, and incorrectly uses 'additionalProperties: false' instead of 'unevaluatedProperties: false'.
- [Low] C preprocessor `#include` directives are placed in the middle of the example DTS block, after a node definition.
--

commit afc648784a49832d73d043919a9fa8c27e4ca3ae
Author: Chris Morgan <macromorgan@hotmail.com>

dt-bindings: power: supply: sgm41542: document sgm41542

This commit documents the SGMicro sgm41542 battery charger and boost
converter. It defines the hardware bindings, including custom input
current and voltage limits, interrupts, and monitored battery references.

> diff --git a/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542.yaml b/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/sgmicro,sgm41542.yaml

[ ... ]

> +  interrupts:
> +    maxItems: 1
> +
> +  monitored-battery:
> +    description: |
> +        A phandle to a monitored battery node. Values for the following
> +        are used by the driver and if not present will result in default
> +        values being applied:

[Severity: Low]
Since this device acts as a battery charger, should it include an
allOf block with a $ref to power-supply.yaml? Without it, standard
properties like monitored-battery lack their inherited type definitions.

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Low]
If this schema is updated to reference the core power-supply schema,
does this need to be changed to unevaluatedProperties: false? Using
additionalProperties: false without inheriting the common power-supply
schema causes schema validation to strictly reject any other standard
power-supply properties added to the device tree node.

> +
> +examples:
> +  - |
> +    battery: battery {
> +      compatible = "simple-battery";
> +      constant-charge-current-max-microamp = <10000000>;
> +      constant-charge-voltage-max-microvolt = <4350000>;
> +      precharge-current-microamp = <180000>;
> +      charge-term-current-microamp = <300000>;
> +    };
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>

[Severity: Low]
Is it standard to place these include directives after the initial
battery node? While technically valid C preprocessor syntax, DT binding
conventions typically require all include directives to be placed at the
very top of the examples block, prior to defining any nodes.

> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601162951.254968-1-macroalpha82@gmail.com?part=1