Re: [PATCH v4 2/2] hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Mismatch between the driver's regulator node expectation and the device tree binding schema, causing DT regulator properties to be silently ignored and the regulator to be unusable by consumers.
--

commit 66bb21f2d9ec87355cc55cca84538b6ad8d8842c
Author: Syed Arif <arif.syed@hpe.com>

hwmon: (pmbus/max20860a) Add driver for Analog Devices MAX20860A

This commit adds a new PMBus driver for the Analog Devices MAX20860A
step-down DC-DC switching regulator. It provides hardware monitoring for
voltage, current, and temperature, along with optional regulator framework
support.

> diff --git a/drivers/hwmon/pmbus/max20860a.c b/drivers/hwmon/pmbus/max20860a.c
> new file mode 100644
> index 0000000000000..905f916f6c089
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/max20860a.c
[ ... ]
> @@ -0,0 +1,68 @@
[ ... ]
> +#include <linux/regulator/driver.h>
> +#include "pmbus.h"
> +
> +#if IS_ENABLED(CONFIG_SENSORS_MAX20860A_REGULATOR)
> +static const struct regulator_desc max20860a_reg_desc[] = {
> +	PMBUS_REGULATOR_ONE("vout"),

[Severity: High]
Will this prevent the regulator core from matching the device tree node?

The PMBUS_REGULATOR_ONE("vout") macro sets of_match to "vout". During
registration, the regulator core searches for a child node named "vout"
or a parent node with that exact name to associate the of_node.

If the device tree schema expects regulator properties directly on the
parent node (which is typically named generically, like regulator@xx),
will the regulator core fail to match the node?

If the match fails, the regulator is registered with of_node = NULL,
which silently ignores regulator constraints and prevents consumers
from referencing it as a supply.

> +};
> +#endif
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260601184516.919488-1-sanman.pradhan@hpe.com?part=2