Re: [PATCH v4] arm64: dts: qcom: monaco-arduino-monza: Add QCNFA725B support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `shutdown-gpios` polarity in the `wlan-rfkill` node is logically inverted, permanently disabling the WLAN radio during normal operation.
--

commit c96c608f286f34bcc2c474aeeb078a7d4cf17161
Author: Qian Zhang <qian.zhang@oss.qualcomm.com>

arm64: dts: qcom: monaco-arduino-monza: Add QCNFA725B support

This commit adds support for the QCNFA725B M.2 module on the Arduino VENTUNO Q
board. It models the W_DISABLE# line using rfkill-gpio and handles the module
power supply routing through the PMCA6850 PMIC.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index ca14f0ea4dae6..b90397c7000e3 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -153,6 +153,78 @@ vreg_nvme: regulator-3p3-m2 {
>  		enable-active-high;
>  		startup-delay-us = <20000>;
>  	};
> +
> +	wlan-rfkill {
> +		compatible = "rfkill-gpio";
> +		label = "wlan";
> +		radio-type = "wlan";
> +		shutdown-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;

[Severity: High]
The commit message states that pulling GPIO54 low disables the transmitter
at the hardware level.

Since the rfkill-gpio driver treats shutdown-gpios as an active enable
signal, won't setting this to GPIO_ACTIVE_LOW cause the driver to physically
drive the pin low when the radio is supposed to be unblocked?

When the radio is unblocked, the driver asserts the GPIO logically. Because
the device tree defines the pin as active low, a logical 1 translates to a
physical 0. This would disable the radio during normal operation and enable
it during airplane mode.

Should this polarity be specified as GPIO_ACTIVE_HIGH instead?

> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wlrfkill_default_state>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602070530.4194262-1-qian.zhang@oss.qualcomm.com?part=1