Re: [PATCH v5 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding and add mahua

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added device tree binding for `qcom,glymur-tcsr` and `qcom,mahua-tcsr` acts as a clock and reset provider but fails to include `#clock-cells`, `#reset-cells`, and `reg` in the top-level `required` list.
--

commit 8298df55a145b1e4fe01a82f3967af5caf49184d
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move glymur TCSR to own binding and add mahua

This commit extracts the TCSR control interface for QREF on glymur and mahua
into its own binding file. It documents the LDO supply properties and sets up
conditional required lists based on the compatible string.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> new file mode 100644
> index 0000000000000..2b64226271657
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml

[ ... ]

> +        - vdda-refgen3-0p9-supply
> +        - vdda-refgen3-1p2-supply
> +
> +required:
> +  - compatible
> +  - clocks

[Severity: Medium]
Should '#clock-cells', '#reset-cells', and 'reg' be added to this global
required list?

Since this binding acts as a clock and reset provider, omitting the
corresponding cell-count properties allows incomplete device tree nodes to
silently pass schema validation. The 'reg' property is also typically
required for a memory-mapped syscon provider.

> +
> +additionalProperties: false
> +
> +examples:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tcsr_qref_0527-v5-0-8ea174a59d7e@oss.qualcomm.com?part=1