From: sashiko-bot@kernel.org
To: "Baojun Xu" <baojun.xu@ti.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: ti,tas2781: Add TAS2573 support
Date: Tue, 02 Jun 2026 10:16:07 +0000 [thread overview]
Message-ID: <20260602101608.5B0971F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260602100532.6463-1-baojun.xu@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-binding schema enforces mutually exclusive `reg` constraints for `ti,tas2573`, causing schema validation to always fail for this device.
--
commit fae137d4c240a643a606f184ad877663a7719392
Author: Baojun Xu <baojun.xu@ti.com>
ASoC: dt-bindings: ti,tas2781: Add TAS2573 support
The TAS2573 belongs to the TAS257x device family, featuring an integrated
DSP and IV sensing capability. This commit adds support for the TAS2573
to the ti,tas2781 dt-binding schema.
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index b21466bb0730a..aa5a317b5a361 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
[ ... ]
> @@ -183,6 +187,7 @@ allOf:
> contains:
> enum:
> - ti,tas2563
> + - ti,tas2573
> - ti,tas5825
> then:
> properties:
[Severity: Medium]
Will these mutually exclusive reg constraints cause a regression during
schema validation for ti,tas2573?
Since the schema requires ti,tas2573 to have ti,tas2781 as a fallback in the
compatible array, a device tree node will typically have:
compatible = "ti,tas2573", "ti,tas2781";
This triggers the conditional block here, restricting reg addresses to
0x4c-0x4f.
However, it also triggers the later conditional block for ti,tas2781, which
restricts reg addresses to 0x38-0x3f.
Since reg cannot satisfy both disjoint ranges simultaneously, will
dt_binding_check always fail for valid ti,tas2573 device trees?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260602100532.6463-1-baojun.xu@ti.com?part=1
prev parent reply other threads:[~2026-06-02 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 10:05 [PATCH v2 1/2] ASoC: dt-bindings: ti,tas2781: Add TAS2573 support Baojun Xu
2026-06-02 10:05 ` [PATCH v2 2/2] ASoC: tas2781: " Baojun Xu
2026-06-02 10:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602101608.5B0971F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=baojun.xu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox