Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	wsa+renesas@sang-engineering.com, robh@kernel.org
Subject: Re: [PATCH v4] arm64: renesas: r8a779g0: add MFIS node
Date: Tue, 02 Jun 2026 18:32:06 +0000	[thread overview]
Message-ID: <20260602183207.40FAB1F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260602182157.304964-2-wsa+renesas@sang-engineering.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced `renesas,r8a779g0-mfis` compatible string lacks corresponding device tree binding documentation.
--

commit 115f5a17688f2c0823c49f8d37bc7d1f7b1d6a27
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>

arm64: renesas: r8a779g0: add MFIS node

This commit adds the MFIS core node, which is used for tasks such as
inter-processor communication, to the r8a779g0 device tree.

> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> index 82a7278836e57..8846bac990864 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
[ ... ]
> @@ -589,6 +589,23 @@ tmu4: timer@ffc00000 {
>  			status = "disabled";
>  		};
>  
> +		mfis: system-controller@e6260000 {
> +			compatible = "renesas,r8a779g0-mfis";

[Severity: Low]
Does this new compatible string have corresponding device tree binding
documentation?

This isn't a bug, but introducing "renesas,r8a779g0-mfis" without an
accompanying schema update will trigger dtbs_check and checkpatch.pl
warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602182157.304964-2-wsa+renesas@sang-engineering.com?part=1

      reply	other threads:[~2026-06-02 18:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 18:21 [PATCH v4] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
2026-06-02 18:32 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260602183207.40FAB1F00898@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox