Re: [PATCH v2 3/3] arm64: dts: qcom: Add the Nothing Phone (3a)

[Rob Herring <robh@kernel.org>]

On Mon, Mar 23, 2026 at 01:55:05PM +0000, Alexander Koskovich wrote:
> Add a devicetree for the Nothing Phone (3a) smartphone, which is based
> on the Milos/SM7635 SoC.
> 
> Supported functionality as of this initial submission:
> * Camera flash/torch LED
> * Debug UART
> * Glyph LEDs (AW20036)
> * PMIC-GLINK (Charger, Fuel gauge, USB-C mode switching)
> * Assistant Key, Power Button, Volume Keys
> * Regulators (PM7550, PM8550VS, PMR735B)
> * Remoteprocs (ADSP, CDSP, MPSS, WPSS)
> * USB (USB2 + FSA4480)
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
>  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>  .../boot/dts/qcom/milos-nothing-asteroids.dts      | 964 +++++++++++++++++++++
>  2 files changed, 965 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index f80b5d9cf1e8..bb7ac369682c 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -44,6 +44,7 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo
>  
>  dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk-el2.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= milos-fairphone-fp6.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= milos-nothing-asteroids.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= monaco-evk.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= msm8216-samsung-fortuna3g.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-acer-a1-724.dtb
> diff --git a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> new file mode 100644
> index 000000000000..7393978926e4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> @@ -0,0 +1,964 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +
> +/dts-v1/;
> +
> +#define PMIV0104_SID 7
> +
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "milos.dtsi"
> +#include "pm7550.dtsi"
> +#include "pm8550vs.dtsi"
> +#include "pmiv0104.dtsi" /* PMIV0102 */
> +#include "pmk8550.dtsi" /* PMK7635 */
> +#include "pmr735b.dtsi"
> +
> +/ {
> +	model = "Nothing Phone (3a)";
> +	compatible = "nothing,asteroids", "qcom,milos";
> +	chassis-type = "handset";
> +
> +	aliases {
> +		serial0 = &uart5;
> +	};
> +
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		stdout-path = "serial0:115200n8";
> +
> +		framebuffer0: framebuffer@e3940000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0xe3940000 0x0 (2392 * 1080 * 4)>;
> +			width = <1080>;
> +			height = <2392>;
> +			stride = <(1080 * 4)>;
> +			format = "a8r8g8b8";
> +			panel = <&panel>;
> +			interconnects = <&mmss_noc MASTER_MDP QCOM_ICC_TAG_ALWAYS
> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> +			clocks = <&gcc GCC_DISP_HF_AXI_CLK>;
> +
> +			/* Dummy panel for simple-framebuffer dimension info */
> +			panel: dummy-panel {
> +				compatible = "boe,bf068mwm-td0";

This is missing documentation and gives a warning. However, having a 
panel node here is not valid. Either define a complete panel node or 
none at all. That should throw a warning as well.

Please send fixes for this and any other warnings you didn't check or 
ignored.

> +				height-mm = <157>;
> +				width-mm = <71>;
> +			};
> +		};
> +	};


Rob