From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED812D238F; Wed, 3 Jun 2026 16:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504998; cv=none; b=IfZxZq6zHigkd+1hqyCt3AZYrGnerD9pjshzDhgrviiSPDxBr4csX94Prd+kxiOQdy1J73mmyJuakv3Sa5wnVZg4axkDrf/vsk64T65Y/eFMeZKDX3Pp6Pw0gax3hR54xJ9vyHo+Y3N9lCQMafPEcUsKTodRis3rnlNLXpatCag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504998; c=relaxed/simple; bh=dntpDrMGqALzXTr+vxV/nyexYipxCv7gzTVl+1ltPdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FEzLPK5XYO27U2sc3gCEfAUW4FGGBtfQkLJf8IZ9gUf0kSGQ7mphJ3vUQpaztMPclUqamrEu/uT5jGpLAJaXsh8YxHCJl8XWwso7ieLBDL83/Tl2jUk/HEJxoPp0ybOledT+madGOmxkGp/DJr6HjR4sQRx1hCD9Iny2zNnqwyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C7BrbTck; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C7BrbTck" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 955271F00898; Wed, 3 Jun 2026 16:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780504996; bh=Z4JstCrvgUHq+IUxWBlO/QMKc5rWKAgnPJ1UKfXNnss=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=C7BrbTckQvXcWoV7k+AEBCsEVHxBwBKyRVbQMNUucK6Up4k+mlR/D2B+ty9bTqLC6 TXyYpg2iAmZbYrcSf/IMx42niQl+mHUvOCBb0t+zktt8WMQQcFeeZ+L8BsSY4TYrFe SMxLlsrDm6jSETCY+mtmezh1ig1ZWzqM8StHwFWddZgXGWQRMy7Lzaz1dLLvobS5Ii dA0lkSooslWUAphAp8eOjJTAjX54a8pnk1nPZ0IJK6im27QMOvdGhM7NfhvaKPvaXt s7dJq2RJ1BZSMP41cVQv4yxHtDPtyuHL388CA2+C9GMN7wvIH310E7UgCTsSDcd20Z it1IkgBNDLRfQ== Date: Wed, 3 Jun 2026 17:43:11 +0100 From: Conor Dooley To: Changhuang Liang Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Paul Walmsley , Albert Ou , Palmer Dabbelt , Alexandre Ghiti , Philipp Zabel , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Lianfeng Ouyang Subject: Re: [PATCH v3 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl Message-ID: <20260603-groin-valid-a1d4445f7a6b@spud> References: <20260603055347.66845-1-changhuang.liang@starfivetech.com> <20260603055347.66845-4-changhuang.liang@starfivetech.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nFVpdkwrvTMCfj3J" Content-Disposition: inline In-Reply-To: <20260603055347.66845-4-changhuang.liang@starfivetech.com> --nFVpdkwrvTMCfj3J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 02, 2026 at 10:53:29PM -0700, Changhuang Liang wrote: > + slew-rate: > + enum: [ 0, 1 ] > + default: 0 > + description: | > + 0: slow (half frequency) Half frequency? Slew rates are usually measured in volts per second, not hertz. Do you know what the slew rates actually are and could put them in here as the real units? Or is it just "slow" and "fast" in your docs with no precise numbers? I've got no questions other than this, so once this question is sorted, I'll be happy to ack all the bindings provided they're effectively the same. > + 1: fast --nFVpdkwrvTMCfj3J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaiBZnwAKCRB4tDGHoIJi 0vpAAPiFQ0YARyxgZCQaUynrtzsvBAbt0yy5kxy2vpklo/C5AQDWjzznOIi1/0El tLNQlHJKrwJ3v5PG6RXO8m1+IwCdBA== =GdZR -----END PGP SIGNATURE----- --nFVpdkwrvTMCfj3J--