Re: [PATCH v2 1/4] dt-bindings: net: ethernet-phy: move clocks property to invidivual PHY bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing `clocks` from the common `ethernet-phy.yaml` without propagating it to dependent PHY schemas breaks schema validation.
--

commit 670ca8e864ec47d85a59d1ab5fa91fe5fe6d6c54
Author: George Moussalem <george.moussalem@outlook.com>

dt-bindings: net: ethernet-phy: move clocks property to invidivual PHY bindings

Move the clock property and restriction from the ethernet-phy.yaml file
to the individual PHY binding files. This allows each PHY to manage its
own clock requirements.

> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> index 21a1a63506f01..709ea976ef790 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -105,12 +105,6 @@ properties:
>        1BR-10 names. The PHY must be configured to operate in BroadR-Reach mode
>        by software.
>  
> -  clocks:
> -    maxItems: 1
> -    description:
> -      External clock connected to the PHY. If not specified it is assumed
> -      that the PHY uses a fixed crystal or an internal oscillator.
> -

[Severity: Medium]
Does removing the clocks property from the common ethernet-phy.yaml break
schema validation for other dependent PHY bindings?

Bindings such as Documentation/devicetree/bindings/net/micrel.yaml enforce
unevaluatedProperties: false and depend on this parent schema. Since they
do not define the clocks property themselves, will any valid device tree
configuring a hardware clock for these PHYs now fail dtbs_check with an
unevaluated property error?

For example, micrel.yaml allows clock-names, which logically requires a
clocks property to be present in the device tree, but without inheriting
it from ethernet-phy.yaml, it now lacks the schema allowance for it.

Could the clocks property be added to all dependent PHY bindings at the
same time it is removed from the common schema to prevent dtbs_check
breakages?

>    enet-phy-lane-swap:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-ipq5018-gephy-clocks-v2-0-65a1f1d881f3@outlook.com?part=1