Re: [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs42xx8: Add SPI bus support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Conflicting GPIO cell counts for the '&gpio' phandle in the newly added SPI example.
--

commit f4759f9ac7c7f10e085045f8fabd1df333354abf
Author: Chancel Liu <chancel.liu@nxp.com>

ASoC: dt-bindings: cirrus,cs42xx8: Add SPI bus support

This commit adds SPI control interface support to the CS42448/CS42888 codec
bindings, which can operate at up to 6MHz. It updates the schema with SPI
properties and provides a new SPI example configuration.

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42xx8.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42xx8.yaml
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs42xx8.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42xx8.yaml

[ ... ]

> @@ -86,3 +90,22 @@ examples:
>            reset-gpios = <&gpio 1>;
>        };
>      };
> +
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      cs-gpios = <&gpio 8 0>;
> +
> +      codec@0 {
> +          compatible = "cirrus,cs42888";
> +          reg = <0>;
> +          spi-max-frequency = <6000000>;
> +          clocks = <&codec_mclk 0>;
> +          clock-names = "mclk";
> +          VA-supply = <&reg_audio>;
> +          VD-supply = <&reg_audio>;
> +          VLS-supply = <&reg_audio>;
> +          VLC-supply = <&reg_audio>;
> +          reset-gpios = <&gpio 1>;

[Severity: Low]
Will this cause a dt_binding_check failure due to a cell size mismatch?

The cs-gpios property uses 2 argument cells for the &gpio phandle, but
reset-gpios uses 1 argument cell for the exact same &gpio label.

A single device tree node can only have a single #gpio-cells value. When
dt_binding_check auto-generates a dummy node for the unresolved &gpio
reference, it will infer a #gpio-cells value that conflicts with one of
these references. 

Should a different label (e.g., &gpio2) be used for cs-gpios, or should
reset-gpios be updated to use 2 cells?

> +      };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603095041.3906558-1-chancel.liu@oss.nxp.com?part=1