Re: [PATCH v4 4/4] arm64: dts: freescale: Add dual-channel LVDS overlay for TQMa8MPxS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing deletion of the original 'port' node when adding 'ports' to 'panel_lvds0', causing DT schema violations and broken bidirectional links.
--

commit f3c8e1f6a8535dc5df481fba1097371fa89698ff
Author: Alexander Stein <alexander.stein@ew.tq-group.com>

arm64: dts: freescale: Add dual-channel LVDS overlay for TQMa8MPxS

This adds an overlay for the supported LVDS display AUO G133HAN01.
Configure the video PLL frequency to exactly match typical pixel clock of
141.200 MHz.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso
> new file mode 100644
> index 0000000000000..9595cf4d43cd0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpqs-mb-smarc-2-lvds-g133han01.dtso
[ ... ]
> +&panel_lvds0 {
> +	compatible = "auo,g133han01";
> +	status = "okay";
> +
> +	ports {

[Severity: Low]
Does this overlay need to explicitly remove the original port node using
/delete-node/ port;?

The base device tree defines panel_lvds0 with a single port node. Because
device tree overlays merge rather than overwrite nodes, the original port
node remains in the merged tree alongside this new ports node.

This violates the OF graph device tree schema which enforces
oneOf: [port, ports]. It also breaks the OF graph bidirectional link
requirement, as the old endpoint points to ldb_lvds_ch0, but ldb_lvds_ch0
no longer points back to it, triggering a remote-endpoint is not
bidirectional error in dtbs_check.

> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603093621.2504490-1-alexander.stein@ew.tq-group.com?part=4