From: sashiko-bot@kernel.org
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v8 1/5] dt-bindings: thermal: Add Google GS101 TMU
Date: Wed, 03 Jun 2026 13:30:45 +0000 [thread overview]
Message-ID: <20260603133045.91C231F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260603-acpm-tmu-v8-1-0f1810a356e6@linaro.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The multi-paragraph 'description' property uses a plain scalar instead of a block scalar, which will cause a fatal YAML parsing error.
--
commit 06fc30400124edc9c117ec855478708d26e9b289
Author: Tudor Ambarus <tudor.ambarus@linaro.org>
dt-bindings: thermal: Add Google GS101 TMU
This commit adds device tree bindings for the Thermal Management Unit (TMU)
found on the Google GS101 SoC. The hardware is managed in a hybrid fashion
shared between the Application Processor (AP) and the ACPM firmware.
> diff --git a/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml
> new file mode 100644
> index 0000000000000..75560ebca48d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml
[ ... ]
> +maintainers:
> + - Tudor Ambarus <tudor.ambarus@linaro.org>
> +
> +description:
> + The Samsung Exynos ACPM TMU is a thermal sensor block found on Exynos
> + based platforms (such as Google GS101 and Exynos850). It supports
> + both direct register-level access and firmware-mediated management
> + via the ACPM (Alive Clock and Power Manager) firmware.
> +
> + On these platforms, the hardware is managed in a hybrid fashion. The
[Severity: Low]
Is this description block missing a block scalar indicator like '|' or '>'?
In YAML, plain scalars cannot contain empty lines. The empty line between the
first and second paragraphs terminates the plain scalar. The YAML parser will
then attempt to parse the next paragraph as a new dictionary key, leading to a
syntax error during make dt_binding_check.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-acpm-tmu-v8-0-0f1810a356e6@linaro.org?part=1
next prev parent reply other threads:[~2026-06-03 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 13:00 [PATCH v8 0/5] thermal: samsung: Add support for Google GS101 TMU Tudor Ambarus
2026-06-03 13:00 ` [PATCH v8 1/5] dt-bindings: thermal: Add " Tudor Ambarus
2026-06-03 13:30 ` sashiko-bot [this message]
2026-06-03 13:00 ` [PATCH v8 2/5] thermal: samsung: Add Exynos ACPM TMU driver GS101 Tudor Ambarus
2026-06-03 13:40 ` sashiko-bot
2026-06-03 13:00 ` [PATCH v8 3/5] MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver Tudor Ambarus
2026-06-03 13:00 ` [PATCH v8 4/5] arm64: dts: exynos: gs101: Add thermal management unit Tudor Ambarus
2026-06-03 13:00 ` [PATCH v8 5/5] arm64: defconfig: enable Exynos ACPM thermal support Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603133045.91C231F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox