From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76FE388899; Wed, 3 Jun 2026 14:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495309; cv=none; b=d2gikPSwc/CsD3GpFyR3l79ZCPpyyF7lGR9ES5tuPRCjPNy8wrKYZ5151zR1JAl0KZK3A1cwFWzygH2wwhqdRFzduoRnj6HKiHU4gNaqgrBI6/3E9HLcOTVzcBCWeQpVOQM6cPR8H6K3oXo2L4HoCpmmPAtfXBmWQ8Vvivd12Zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495309; c=relaxed/simple; bh=M315hU5DlmoQogmEpkRIOLIC3KrZiKVjBvweznqrv6k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bAtKmmSZgUTQFOlM3NeYoj7FA4nWriHGoKZgDkwjPrsTP4QgCwV4ZGfbgXd1Armoda8OUorTEH0u2UkxC2xmxkOjIgVUoUK7E3GJmy7cp1B/6tin/eO57TplaZ2Gin6IFNuvv4/DyQ4lnF6D5lXApo7tPjkFZQ1esAhoE5m6RKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K53lA8AB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K53lA8AB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80A1F1F00893; Wed, 3 Jun 2026 14:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780495307; bh=erPqLsRee+i5flGJz3EBlNPGGuEf8itbLMLqINu7so0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=K53lA8ABvipzmSNzPIR8w9ur8yBKY3MOpDgg2TRj4vJ5J2/vRin3adsTFeUWFPyof NdApjQk1a5YBilKX4pJyC+u/eR+6RQBsQM0QeFX9IpdVB/WVJ3eIsqRzT8TAkHmdIG lQBEoJfIDpS+NPlvuvpIg3ZO3RkUT7jpAQcSl2scJyiJti3eAN6U8QV5Og7gT3ggrZ nAhRQ9fomSPiqlcn6sa6GsZoMO4b4y/viJfUXHxBBYprIDyFmoB8QSjkRhj+utgCHm qrMW/AP8R3dXl7Se/LTVglpbT9UxG0QXvsv729ueMaRYQg0xhHo+nsDbc3wChDZI0G Jjp3Ims1U67EQ== Date: Wed, 3 Jun 2026 15:01:39 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Liviu Stan , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Antoniu Miclaus , Francesco Lavra , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@analog.com, devicetree@vger.kernel.org Subject: Re: [PATCH v4 6/9] iio: temperature: ltc2983: Use fwnode_property_present() for optional properties Message-ID: <20260603150139.761333e2@jic23-huawei> In-Reply-To: References: <20260525164013.118614-1-liviu.stan@analog.com> <20260525164013.118614-7-liviu.stan@analog.com> <20260527171945.152279fa@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jun 2026 02:26:17 +0300 Andy Shevchenko wrote: > On Wed, May 27, 2026 at 05:19:45PM +0100, Jonathan Cameron wrote: > > On Mon, 25 May 2026 19:39:33 +0300 > > Liviu Stan wrote: > > > > > Checking fwnode_property_read_u32() return value with if (!ret) > > > silently swallows meaningful error codes when a property is present > > > but malformed. Use fwnode_property_present() first so that absence > > > uses the default while a present but unreadable property returns > > > a proper error. > > > > > > Signed-off-by: Liviu Stan > > Applied, > > With const char *propname defined this all may be made much shorter. True. Maybe an additional cleanup on top for next cycle? >