Re: [PATCH 1/2] dt-bindings: interconnect: qcom: add msm8660 fabric IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly claims the associated driver models the SFPB and CFPB fabrics.
--

commit f2c1f888ae217770de22883ba69e0e4f0206a9ee
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: interconnect: qcom: add msm8660 fabric IDs

This commit adds the interconnect master and slave IDs for the MSM8x60 family
fabric mesh. It defines IDs for the various sub-fabrics including AFAB, SFAB,
MMFAB, DFAB, SFPB, and CFPB based on the legacy vendor driver.

>     The chip's
>     NoC fabric is split into multiple sub-fabrics that the qnoc-msm8660
>     driver models:
>     
>       AFAB  - Applications fabric (Scorpion CPU + L2)
>       SFAB  - System fabric (DMA, SPS, security)
>       MMFAB - Multimedia fabric (MDP, GPU, camera, video, rotator)
>       DFAB  - Daytona fabric (SDC, ADM master/slave)
>       SFPB  - System Fast Peripheral Bridge (RPM, MPM, PMIC SSBI)
>       CFPB  - CPU Subsystem Fast Peripheral Bus (GSBI UART/QUP, USB FS,
>               TSIF, TSSC, PDM, PRNG)

[Severity: Low]
Is this description accurate regarding SFPB and CFPB?

The commit message states that the qnoc-msm8660 driver models SFPB and CFPB,
but looking at the driver implementation introduced in this series, it appears
to only model AFAB, SFAB, MMFAB, and DFAB.

Could the commit message be updated to clarify that SFPB and CFPB are not
actually modeled by the driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603163410.2312712-1-github.com@herrie.org?part=1