Re: [PATCH v6 2/3] arm64: dts: ti: Add k3-am62l3-beaglebadge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Driver-Binding Mismatch: The `mcp23s18` GPIO expander probe will fail due to property size mismatch.
--

commit dda0de04ef0f2160008191753ea45cc6c9880fa6
Author: Judith Mendez <jm@ti.com>

arm64: dts: ti: Add k3-am62l3-beaglebadge

This commit adds the device tree for the BeagleBoard.org BeagleBadge, based on
the Texas Instruments AM62L3 SoC. It includes configurations for memory, GPIO
keys, LEDs, regulators, MMC, USB, PWM, I2C, SPI, and other peripherals.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts b/arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts
> new file mode 100644
> index 0000000000000..ee2d562baf51a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-beaglebadge.dts

[ ... ]

> +&spi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi1_pins_default>;
> +	status = "okay";
> +
> +	mcp23s18: gpio@0 {
> +		compatible = "microchip,mcp23s18";
> +		reg = <0>;
> +		spi-max-frequency = <10000000>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		reset-gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&mcp23s18_reset_pins_default>;
> +		microchip,spi-present-mask = /bits/ 8 <0x01>;

[Severity: High]
Does this 8-bit property cause the driver probe to fail?

Looking at drivers/pinctrl/pinctrl-mcp23s08_spi.c, the driver attempts to read
this property using device_property_read_u32(). Because it expects at least
4 bytes of data, of_find_property_value_of_size() will evaluate the length
as insufficient and return -EOVERFLOW.

This would cause the driver probe to fail, leaving the MCP23S18 GPIO expander
and connected devices non-functional. Should this property be defined as a
standard 32-bit value to match the driver's expectations?

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603192305.1347908-1-jm@ti.com?part=2