Re: [PATCH v1 2/2] arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added gpio-hog node is named `lvds-brg-enable-hog`, but it is documented to control the `RGB_SEL` line and its `line-name` property is set to `rgb_sel`. This is likely a copy-paste error.
--

commit 9c97f65e1888df2bd494aacf3412a0fd8cf0a5db
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

This commit drives the RGB_SEL line low on the Symphony carrier board.
It does this by adding a gpio-hog subnode to the pca6408 GPIO controller
to ensure the board remains in the expected display configuration.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts
> @@ -168,6 +168,14 @@ pca6408: gpio@21 {
>  		reg = <0x21>;
>  		gpio-controller;
>  		#gpio-cells = <2>;
> +
> +		/* RGB_SEL */
> +		lvds-brg-enable-hog {

[Severity: Low]
This isn't a bug, but is this node name a copy-paste error? It is documented
to control RGB_SEL and sets the line-name to "rgb_sel", so a name like
rgb-sel-hog might be more appropriate to avoid confusion.

> +			gpio-hog;
> +			gpios = <7 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +			line-name = "rgb_sel";
> +		};
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780527068.git.stefano.r@variscite.com?part=2