Re: [PATCH net-next v4 5/5] net: dsa: ks8995: Delete surplus driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] NET_DSA_KS8995 selects NET_DSA_MICROCHIP_KSZ_SPI without inheriting its required dependencies.
- [High] The transitional Kconfig option lacks a prompt and is defined as a `bool`, completely breaking the intended user migration.
--

commit b05792c06b27a646be1067e3e5c2643b8b180f96
Author: Linus Walleij <linusw@kernel.org>

net: dsa: ks8995: Delete surplus driver

This commit deletes the old ks8995 switch driver and replaces it with a
Kconfig stub. The stub is intended to transition users to the superseding
NET_DSA_MICROCHIP_KSZ_SPI driver automatically during config migration.

> diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
> index e704ab702c189..6a704b6383ffd 100644
> --- a/drivers/net/dsa/Kconfig
> +++ b/drivers/net/dsa/Kconfig
> @@ -98,13 +98,13 @@ config NET_DSA_RZN1_A5PSW
>  	  RZ/N1 SoC.
>  
>  config NET_DSA_KS8995
> -	tristate "Micrel KS8995 family 5-ports 10/100 Ethernet switches"
> -	depends on SPI
> -	depends on !NET_DSA_MICROCHIP_KSZ_SPI
> -	select NET_DSA_TAG_NONE
> +	bool

[Severity: High]
The commit message states this is a stub to automatically phase users
over to the new symbol when migrating their configs. However, without a
prompt string like bool "Transitional...", doesn't this become a hidden
symbol?

It looks like Kconfig will silently drop the old CONFIG_NET_DSA_KS8995
setting during make oldconfig rather than preserving the user's
selection, which would fail to migrate them to the new driver.

> +	select NET_DSA_MICROCHIP_KSZ_SPI

[Severity: High]
Will selecting NET_DSA_MICROCHIP_KSZ_SPI without inheriting its
dependencies cause unmet direct dependency warnings?

NET_DSA_MICROCHIP_KSZ_SPI depends on NET_DSA_MICROCHIP_KSZ_COMMON and
SPI, but these dependencies are not listed here. Could this lead to
build failures on configurations where the dependencies are not met?

>  	help
> -	  This driver supports the Micrel KS8995 family of 10/100 Mbit ethernet
> -	  switches, managed over SPI.
> +	  This is a transitional option for users who had NET_DSA_KS8995
> +	  enabled. It automatically enables the new NET_DSA_MICROCHIP_KSZ_SPI
> +	  driver which supersedes it. This option will be removed in a future
> +	  kernel release.
>  
>  config NET_DSA_SMSC_LAN9303
>  	tristate

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-ks8995-to-ksz8-v4-0-e15149ef21e7@kernel.org?part=5