From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3153747ECDE; Thu, 4 Jun 2026 17:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780592803; cv=none; b=upwtGUa2NW7iNTkDDIYDNjWhTsc254evpZBiukzma6aevACLl4JNQ51+QEK+rcshA9JVLTJXqsaPvM/cH10+zj9004DfhWm5JUBHbA3rMbQvITaOaUpLYm95e0gHb8g0kqTjg2O8nXY4B0wuxDqDm5xu3SgpiUW6UJ560/5jurg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780592803; c=relaxed/simple; bh=SZONiF7ghlZM9h/Sl8iPCmr9qNxd8DST8TS/saxze24=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IuyYuP2ohEi33/tebNDR6voz3v9vZIyVIdnGsQ/IHqyJ4Q9sMBqqN8ExlMQ8tU/Lsxlxu44XjS67yiQrz4sAEY+3A2BsPlA47fupIUFJRCaJVW8DyA4QXioHhYaqi5HTe8vooFo3w2CCvQ28VvYxlE4Loyzt258Q90PZLkaJAVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TITIy85J; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TITIy85J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD0581F00893; Thu, 4 Jun 2026 17:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780592800; bh=THDk6fTtan6fuBzI69SEywQVTp9gJKd2GNHSC2lTvFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TITIy85JoinwJOkeT5cbUxS/Vc16E4lfxP7pIaD+by7otBrL5scyE0dw/MHtsFjfT BWnjXNl402YIxvA+X6fqqtX7VPAbhzOYFQd/rX2/xhtWtntIg+68nzjnDY4q9mmqgH uTG05lAUAOKwGUNbdxI79lFxAkT4bZqdg4bOmB9qoccvuaaxOlbO55ijuq+C9Q3SyM A+YqCOwt9n+uIrGqeBYZFtNWLA35/G/aznjyGmkFGoINwv/ZNsEfZacjIftDlPiY13 t4cRtRPjwalb1xr/DYiIkE89mRuUGrk2k0AbteQSoKqLSQYqT3Ek8C5ZRCZosVqxFp 9Fhs5n5Vfwh6A== Date: Thu, 4 Jun 2026 18:06:35 +0100 From: Conor Dooley To: Changhuang Liang Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Paul Walmsley , Albert Ou , Palmer Dabbelt , Alexandre Ghiti , Philipp Zabel , Bartosz Golaszewski , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Lianfeng Ouyang Subject: Re: [PATCH v3 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl Message-ID: <20260604-sprout-zips-c2c29e26fe1d@spud> References: <20260603055347.66845-1-changhuang.liang@starfivetech.com> <20260603055347.66845-4-changhuang.liang@starfivetech.com> <20260603-groin-valid-a1d4445f7a6b@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MzAYvu0zafqbmMzc" Content-Disposition: inline In-Reply-To: --MzAYvu0zafqbmMzc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 04, 2026 at 01:37:00AM +0000, Changhuang Liang wrote: > Hi, Conor >=20 > Thanks for the review. >=20 > > On Tue, Jun 02, 2026 at 10:53:29PM -0700, Changhuang Liang wrote: > >=20 > > > + slew-rate: > > > + enum: [ 0, 1 ] > > > + default: 0 > > > + description: | > > > + 0: slow (half frequency) > >=20 > > Half frequency? Slew rates are usually measured in volts per second, no= t hertz. > > Do you know what the slew rates actually are and could put them in here= as > > the real units? Or is it just "slow" and "fast" in your docs with no pr= ecise > > numbers? >=20 > Yes, there are no precise numbers in our documentation. I will remove "(h= alf frequency)" in the next version. If the rate is actually half, then you can say that. It's just "frequency" I was objecting to. >=20 > > I've got no questions other than this, so once this question is sorted,= I'll be > > happy to ack all the bindings provided they're effectively the same. > >=20 > > > + 1: fast >=20 > Best Regards, > Changhuang --MzAYvu0zafqbmMzc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaiGwmwAKCRB4tDGHoIJi 0nJAAQDvcEDwiD+3GTqQxZ57p33w5TBg+tRlXUgDnfGimF7w0wEApwva9vTpq3gk vsB+mH5qfJJ7+KJ91nAQQG2RyRvuiQ0= =h0/2 -----END PGP SIGNATURE----- --MzAYvu0zafqbmMzc--