Re: [PATCH v5 1/2] dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `clocks` property is used in the binding example but is not declared in the `properties` block, causing `dt_binding_check` to fail.
--

commit 2429ce4ee39320cf5271a51cef0c60497b97ce80
Author: Hongliang Wang <wanghongliang@loongson.cn>

dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties

This commit adds clocks and clock-frequency properties to the
loongson,ls2x-i2c dt-binding examples.

Cc: stable@vger.kernel.org
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Hongliang Wang <wanghongliang@loongson.cn>

> diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> index 67882ec6e06af..baa26684bbed0 100644
> --- a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> @@ -33,11 +33,14 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/loongson,ls2k-clk.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>  
>      i2c0: i2c@1fe21000 {
>          compatible = "loongson,ls2k-i2c";
>          reg = <0x1fe21000 0x8>;
> +        clock-frequency = <100000>;
> +        clocks = <&clk LOONGSON2_APB_CLK>;

[Severity: Low]
Will this cause dt_binding_check to fail? The schema specifies
unevaluatedProperties: false, and while clock-frequency is pulled in
from the referenced i2c-controller.yaml schema, clocks is not explicitly
defined in the properties block.

Should the clocks property be added to the properties block to prevent
validation errors on the example?

>          interrupt-parent = <&extioiic>;
>          interrupts = <22 IRQ_TYPE_LEVEL_LOW>;
>          #address-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604015848.18643-1-wanghongliang@loongson.cn?part=1