Re: [PATCH v1] arm64: dts: imx94: Add Root Port node and PERST property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added Root Port PERST# properties incorrectly use `reset-gpio` instead of `reset-gpios`, causing the PCI core to silently ignore them, violating DT schema, and falling back to the deprecated legacy binding.
--

commit 10fdcd113cd4d5825e1430558167b9577d3cf633
Author: Richard Zhu <hongxing.zhu@oss.nxp.com>

arm64: dts: imx94: Add Root Port node and PERST property

This commit adds Root Port nodes to the i.MX943 PCIe controllers and attempts
to migrate the PERST reset property from the host bridge to these new Root
Port nodes.

> diff --git a/arch/arm64/boot/dts/freescale/imx943-evk.dts b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> index 7cfd424689507..ed3abd3e76e56 100644
> --- a/arch/arm64/boot/dts/freescale/imx943-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> @@ -1034,12 +1034,17 @@ &pcie0 {

[ ... ]

> +	/* This property is deprecated, use reset-gpios from the Root Port node. */
>  	reset-gpio = <&pcal6416_i2c3_u46 3 GPIO_ACTIVE_LOW>;
>  	vpcie3v3aux-supply = <&reg_m2_wlan>;
>  	supports-clkreq;
>  	status = "okay";
>  };
>  
> +&pcie0_port0 {
> +	reset-gpio = <&pcal6416_i2c3_u46 3 GPIO_ACTIVE_LOW>;
> +};

[Severity: Medium]
The commit message mentions adding the reset-gpios property, but is it
intended to use reset-gpio here instead?

The Linux PCI core function pci_host_common_parse_perst() explicitly parses
the Root Port's reset GPIO using of_property_present(np, "reset-gpios"),
which strictly checks for the plural form.

Because of this typo, will the Root Port's PERST GPIO be ignored, causing
the driver to fall back to imx_pcie_parse_legacy_binding() to parse the
deprecated legacy property left on the Host Bridge node? This appears to
defeat the migration effort and violate the PCI bus DT schema.

>  
>  &pcie0_ep {

[ ... ]

> @@ -1058,12 +1063,17 @@ &pcie1 {

[ ... ]

> +	/* This property is deprecated, use reset-gpios from the Root Port node. */
>  	reset-gpio = <&pcal6416_i2c3_u46 1 GPIO_ACTIVE_LOW>;
>  	vpcie3v3aux-supply = <&reg_slot_pwr>;
>  	supports-clkreq;
>  	status = "okay";
>  };
>  
> +&pcie1_port0 {
> +	reset-gpio = <&pcal6416_i2c3_u46 1 GPIO_ACTIVE_LOW>;
> +};

[Severity: Medium]
Does this also suffer from the same typo as the pcie0_port0 node?

Using reset-gpio instead of reset-gpios will likely cause this property
to be similarly ignored by the PCI core's Root Port parser.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604022420.120294-1-hongxing.zhu@oss.nxp.com?part=1