Re: [PATCH 1/2] dt-bindings: leds: Add default-intensity property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The example in `leds-pwm-multicolor.yaml` incorrectly uses `linux,default-intensity` instead of the newly defined `default-intensity` property, causing dt_binding_check validation to fail.
- [Low] The description for `default-intensity` contains a grammatical error that makes the sentence confusing.
--

commit 99b08e914db877e1b3d69129c24e623ae6ddf4d3
Author: Jonas Rebmann <jre@pengutronix.de>

dt-bindings: leds: Add default-intensity property

Document the default-intensity property to set a default color on
multicolor LEDs. Update pwm-multicolor to support it and update the example
to turn the LED red on boot.

> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f4e44b33f56d1..159a89f77982b 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -73,6 +73,16 @@ properties:
>        - keep
>      default: off
>  
> +  default-intensity:
> +    description:
> +      The initial intensity of the LED color component. Used only during
> +      initialization. Defaults to 0. As the intensity of each sub-LED is
> +      multiplied with the overall brightness, without this property on a
> +      sub-LED is effectively initialized at minimum brightness regardless of

[Severity: Low]
This isn't a bug, but there appears to be a grammatical error in this sentence.
Should it be "without this property, a sub-LED is effectively initialized"
instead of "without this property on a sub-LED is effectively initialized"?

> +      its linux,default-trigger and default-brightness attributes.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0
> +

[ ... ]

> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> index a31a202afe5cc..05cc83f4bb825 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml

[ ... ]

> @@ -63,12 +65,14 @@ examples:
>  
>          multi-led {
>              color = <LED_COLOR_ID_RGB>;
> +            linux,default-trigger = "default-on";
>              function = LED_FUNCTION_INDICATOR;
>              max-brightness = <65535>;
>  
>              led-red {
>                  pwms = <&pwm1 0 1000000>;
>                  color = <LED_COLOR_ID_RED>;
> +                linux,default-intensity = <65535>;

[Severity: Low]
Is this example property name correct? The new property is defined as
default-intensity, not linux,default-intensity. Does this mismatch cause
schema validation to fail during make dt_binding_check?

>              };
>  
>              led-green {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-multicolor-default-v1-0-b07bff431537@pengutronix.de?part=1