Re: [PATCH 3/3] arm64: dts: realtek: Add I/O level detector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree compilation fails due to undefined labels `iso_pinctrl` and `main2_pinctrl`.
--

commit 3280d12b516149efbcad054728b0302fe3fcc602
Author: Yu-Chun Lin <eleanor.lin@realtek.com>

arm64: dts: realtek: Add I/O level detector

Add io-level-detector node with pinctrl configurations for 1.8V/3.3V
voltage selection on RGMII, SDIO, CSI, SD, UART1, AIO, and eMMC.

> diff --git a/arch/arm64/boot/dts/realtek/kent-pinctrl.dtsi b/arch/arm64/boot/dts/realtek/kent-pinctrl.dtsi
> new file mode 100644
> index 0000000000000..ec7e33034b967
> --- /dev/null
> +++ b/arch/arm64/boot/dts/realtek/kent-pinctrl.dtsi
> @@ -0,0 +1,108 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Copyright (c) 2022-2026 Realtek Semiconductor Corp.
> + */
> +
> +&iso_pinctrl {

[Severity: Low]
Are the labels iso_pinctrl and main2_pinctrl defined anywhere in the device
tree sources?

It appears this causes a DTC compilation error due to using an undefined
label as an overlay target.

> +	aio_vsel_1v8_pins: aio-vsel-1v8-pins {

[ ... ]

> +	uart1_vsel_3v3_pins: uart1-vsel-3v3-pins {
> +		pins = "gpio_8", "gpio_9", "gpio_10", "gpio_11";
> +		power-source = <1>;
> +		input-threshold-voltage-microvolt = <3300000>;
> +	};
> +};
> +
> +&main2_pinctrl {

[Severity: Low]
Does this node also cause a DTC compilation error due to main2_pinctrl being
undefined?

> +	emmc_vsel_1v8_pins: emmc-vsel-1v8-pins {

[ ... ]

> diff --git a/arch/arm64/boot/dts/realtek/kent.dtsi b/arch/arm64/boot/dts/realtek/kent.dtsi
> index ae006ce244205..54e7e2e1cb53d 100644
> --- a/arch/arm64/boot/dts/realtek/kent.dtsi
> +++ b/arch/arm64/boot/dts/realtek/kent.dtsi

[ ... ]

> @@ -125,6 +125,32 @@ psci: psci {
>  		method = "smc";
>  	};
>  
> +	io_level_detector: io-level-detector {
> +		compatible = "realtek,rtd1625-io-detect";

[ ... ]

> +		pinctrl-12 = <&emmc_vsel_1v8_pins>;
> +		pinctrl-13 = <&emmc_vsel_3v3_pins>;
> +		realtek,iso-pinctrl = <&iso_pinctrl>;

[Severity: Low]
Will this phandle reference cause a compilation failure since iso_pinctrl
appears to be undefined?

> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604111821.975624-1-eleanor.lin@realtek.com?part=3