From: sashiko-bot@kernel.org
To: "Lukas Schmid" <lukas.schmid@netcube.li>
Cc: conor+dt@kernel.org, linux-sunxi@lists.linux.dev,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)
Date: Thu, 04 Jun 2026 12:12:18 +0000 [thread overview]
Message-ID: <20260604121219.3CBD01F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260604115241.1358528-4-lukas.schmid@netcube.li>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `gpio-line-names` array incorrectly swaps the labels for the I2C2 and I2C3 buses.
- [Low] The `gpio-line-names` array duplicates the `uSD_CLK` label and is missing the `uSD_CMD` label.
--
commit 29f0ec8865f8acd19ab87f4cdc6247b24643400b
Author: Lukas Schmid <lukas.schmid@netcube.li>
Subject: ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann)
This commit adds a new device tree for the NetCube Systems OpenNMC
(dobermann), which is based on the Nagami System-on-Module. It defines
hardware configurations for various interfaces including LEDs, USB, I2C,
and sets up GPIO line names.
> diff --git a/arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts b/arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts
> new file mode 100644
> index 0000000000000..97dd4b950dd8a
> --- /dev/null
> +++ b/arch/arm/boot/dts/allwinner/sun8i-t113s-netcube-dobermann.dts
[ ... ]
> @@ -0,0 +1,149 @@
[ ... ]
> +&pio {
> + gpio-line-names = "", "", "", "", // PA
[ ... ]
> + "", "", "", "", // PD
> + "", "", "", "",
> + "", "USB_SEC_EN", "EXT_SPI_nCS", "EXT_SPI_SCK",
> + "EXT_SPI_MOSI", "EXT_SPI_MISO", "EXT_IO5", "EXT_IO4",
> + "SMART_SEL", "", "", "",
> + "I2C3_SCL", "I2C3_SDA", "TUSB320_nINT", "",
[Severity: Low]
Are the labels for I2C2 and I2C3 swapped here?
According to the sunxi-d1s-t113.dtsi pinctrl definitions, PD20 and PD21 are
typically associated with I2C2. However, the labels defined here indicate
I2C3.
> + "", "", "", "",
> + "", "", "", "",
> + "ETH_CRSDV", "ETH_RXD0", "ETH_RXD1", "ETH_TXCK", // PE
[ ... ]
> + "", "", "", "",
> + "uSD_D1", "uSD_D0", "uSD_CLK", "uSD_CLK", // PF
[Severity: Low]
Is this missing the uSD_CMD label?
Both PF2 and PF3 are identically labeled as uSD_CLK, which exposes a
conflicting pin name to userspace utilities.
> + "uSD_D3", "uSD_D2", "TUSB320_ID", "",
[ ... ]
> + "", "", "", "",
> + "ESP_CLK", "ESP_CMD", "ESP_D0", "ESP_D1", // PG
> + "ESP_D2", "ESP_D3", "ESP_TXD", "ESP_RXD",
> + "ESP_nBOOT", "ESP_nRST", "I2C2_SCL", "I2C2_SDA",
[Severity: Low]
Similar to the PD pins above, should PG10 and PG11 be labeled as I2C3
instead of I2C2?
> + "EXT_IO1", "EXT_IO0", "LED_HEARTBEAT", "SD_DETECT",
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260604115241.1358528-1-lukas.schmid@netcube.li?part=3
prev parent reply other threads:[~2026-06-04 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 11:52 [PATCH v1 0/3] Add support for NetCube Systems OpenNMC (dobermann) Lukas Schmid
2026-06-04 11:52 ` [PATCH v1 1/3] dt-bindings: arm: sunxi: Add " Lukas Schmid
2026-06-04 12:46 ` Krzysztof Kozlowski
2026-06-04 11:52 ` [PATCH v1 2/3] riscv: dts: allwinner: d1s-t113: Add uart4 pinctrl required by NetCube Systems OpenNMC Lukas Schmid
2026-06-04 11:52 ` [PATCH v1 3/3] ARM: dts: sunxi: add support for NetCube Systems OpenNMC (dobermann) Lukas Schmid
2026-06-04 12:12 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604121219.3CBD01F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lukas.schmid@netcube.li \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox