From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver
Date: Thu, 04 Jun 2026 12:37:52 +0000 [thread overview]
Message-ID: <20260604123753.478461F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260604-shikra-display-v2-2-b3c1b2b67edc@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit adds the Kconfig symbol CONFIG_DRM_PANEL_ILITEK_ILI7807S to the arm64 defconfig, but the symbol and its corresponding driver do not exist in the repository or within this patch series.
--
commit f1a3e380ead347531475952759052c8bc5c76b54
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>
arm64: defconfig: Enable ILI7807S DSI panel driver
This commit enables the ILI7807S 1080x1920 video-mode DSI panel driver as a
module in the arm64 defconfig for the Shikra CQM EVK board.
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 909f3c188e755..a6d72ff63e571 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
[ ... ]
> @@ -1005,6 +1005,7 @@ CONFIG_DRM_MXSFB=m
> CONFIG_DRM_IMX_LCDIF=m
> CONFIG_DRM_NOUVEAU=m
> CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=m
> +CONFIG_DRM_PANEL_ILITEK_ILI7807S=m
[Severity: Low]
Does this config symbol actually exist in the tree yet? It appears that
CONFIG_DRM_PANEL_ILITEK_ILI7807S and its corresponding driver are missing
from the repository and this patch series.
Without the driver being present, will the config tools just silently drop
this addition during make defconfig?
> CONFIG_DRM_PANEL_LVDS=m
> CONFIG_DRM_PANEL_HIMAX_HX8279=m
> CONFIG_DRM_PANEL_HIMAX_HX83112A=m
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-shikra-display-v2-0-b3c1b2b67edc@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-06-04 12:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 12:42 ` sashiko-bot
2026-06-04 12:51 ` Krzysztof Kozlowski
2026-06-04 12:51 ` Dmitry Baryshkov
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-04 12:37 ` sashiko-bot [this message]
2026-06-04 12:53 ` Krzysztof Kozlowski
2026-06-04 12:54 ` Dmitry Baryshkov
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-04 13:04 ` Dmitry Baryshkov
2026-06-04 13:03 ` [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604123753.478461F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox