Devicetree
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Linus Walleij <linusw@kernel.org>
Subject: Re: [PATCH v2 0/3] pinctrl: sunxi: a523: fix GPIO IRQ operation
Date: Thu, 4 Jun 2026 12:54:14 +0200	[thread overview]
Message-ID: <20260604125414.0e361fcf@ryzen.lan> (raw)
In-Reply-To: <20260327113006.3135663-1-andre.przywara@arm.com>

On Fri, 27 Mar 2026 11:30:03 +0000
Andre Przywara <andre.przywara@arm.com> wrote:

Hi,

> this is the minimal fix version for the GPIO IRQ operation on the
> Allwinner A523/A527/T527 SoCs. SD card detection is broken as a result,
> which is a major annoyance. Those patches here fix that problem, and
> should go into v7.0 still, if possible.

what is the status of this series, please? We missed v7.0 back then, but
please can we take this now, for v7.1? There are review tags for every
patch, and this fixes SD card operation on all A523/A527/T572 boards.
The series still applies cleanly on current master, if I should resend
anyway, please let me know.

Cheers,
Andre

> I dropped the more involved fixes from v1, the risk for regressions is
> now very low:
> - The quirk flag is just dropped from the A523, not the other SoCs. I
>   confirmed this again with an experiment, for both the primary and
>   secondary pincontroller. This avoids fixing the workaround code for
>   now, which is more involved, but for now unneeded.
> - The DT patch just adds the missing interrupt. The IRQ association was
>   always wrong and never worked, so this can't make it possibly worse.
> Together those two patches (plus the required binding change) fix the
> problem, I would appreciate if this could be taken ASAP, into v7.0 still.
> The generic pinctrl code is now untouched, which makes this also much
> easier to backport, and drops the dependencies on other v7.0-rc fixes.
> 
> Bases on v7.0-rc1, but applies on later revisions as well.
> 
> Please have a look and test, especially on A523/A527/T527 boards!
> 
> Changelog v1 .. v2:
> - drop generic pinctrl fixes (for now)
> - drop quirk removal from other SoCs (for now)
> - add Chen-Yu's tag
> 
> Cheers,
> Andre
> 
> Andre Przywara (3):
>   pinctrl: sunxi: a523: Remove unneeded IRQ remuxing flag
>   dt-bindings: pinctrl: sun55i-a523: increase IRQ banks number
>   arm64: dts: allwinner: a523: Add missing GPIO interrupt
> 
>  .../bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml   | 8 ++++----
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi            | 3 ++-
>  drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c             | 1 -
>  drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c               | 1 -
>  4 files changed, 6 insertions(+), 7 deletions(-)
> 
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f


      parent reply	other threads:[~2026-06-04 10:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 11:30 [PATCH v2 0/3] pinctrl: sunxi: a523: fix GPIO IRQ operation Andre Przywara
2026-03-27 11:30 ` [PATCH v2 1/3] pinctrl: sunxi: a523: Remove unneeded IRQ remuxing flag Andre Przywara
2026-03-27 11:38   ` Chen-Yu Tsai
2026-04-05 15:27     ` Andre Przywara
2026-03-27 11:39   ` Jernej Škrabec
2026-03-27 11:30 ` [PATCH v2 2/3] dt-bindings: pinctrl: sun55i-a523: increase IRQ banks number Andre Przywara
2026-03-27 11:41   ` Jernej Škrabec
2026-04-07 18:40   ` Rob Herring (Arm)
2026-03-27 11:30 ` [PATCH v2 3/3] arm64: dts: allwinner: a523: Add missing GPIO interrupt Andre Przywara
2026-03-27 11:42   ` Jernej Škrabec
2026-06-04 10:54 ` Andre Przywara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260604125414.0e361fcf@ryzen.lan \
    --to=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox