Re: [PATCH v2 1/2] dt-bindings: interconnect: qcom: add msm8660 NoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#interconnect-cells` property is omitted from the top-level `properties` block and lacks a `const: 1` constraint.
--

commit 6d4f0512e52e66a4b578ad649862cfd9451407db
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: interconnect: qcom: add msm8660 NoC

This commit introduces a device tree binding schema and interconnect ID
header for the Qualcomm MSM8x60 family Network-on-Chip. It defines four
fabric compatible strings, per-fabric clock requirements, and the
necessary RPM phandle to pass arbitration data to the firmware.

> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml
> new file mode 100644
> index 0000000000000..f8b3a05d5ba18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8660.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - qcom,msm8660-apps-fabric
> +      - qcom,msm8660-system-fabric
> +      - qcom,msm8660-mmss-fabric
> +      - qcom,msm8660-daytona-fabric

[Severity: Medium]
Should #interconnect-cells be explicitly defined in this top-level properties
block with a const: 1 constraint?

The inherited common schema (qcom,rpm-common.yaml) permissively allows both
1 and 2 cells, but the MSM8660 interconnect strictly uses 1 cell.

Omitting the const: 1 constraint allows invalid device tree configurations
to silently pass schema validation, and it appears to conflict with the
subsystem guideline requiring that each cell-count property must have an
explicit const constraint matching the hardware.

> +
> +  clocks:
> +    minItems: 2
> +    maxItems: 4

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604184400.801543-1-github.com@herrie.org?part=1